Skip to content

[Algs] add IndexedKeyMultimap #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tdavidcl
Copy link
Member

No description provided.

@tdavidcl tdavidcl linked an issue Sep 18, 2023 that may be closed by this pull request
@tdavidcl tdavidcl added the Draft label Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Pre commit report

Some failures were detected in pre-commit checks.
Check the On PR / Linting / Pre-commit CI (pull_request) job in the tests for more detailled output

❌ Check doxygen headers

The pre-commit checks have found some files without or with a wrong doxygen file header

A properly formed doxygen header should be like and placed just below #pragma once in headers or below the license in source files:

/**
 * @file <filename>
 * @author <Author name> (<email>)
 * @brief <Description of the file content>
 *
 */

This test is triggered if the doxygen header is missing or with the wrong file name

At some point we will refer to a guide in the doc about this

List of files with errors :

  • /src/shamalgs/IndexedKeyMultimap.hpp

❌ trailing-whitespace

Fixing src/shamalgs/IndexedKeyMultimap.hpp

❌ end-of-file-fixer

Fixing src/shamalgs/IndexedKeyMultimap.hpp

Suggested changes

Detailed changes :
diff --git a/src/shamalgs/IndexedKeyMultimap.hpp b/src/shamalgs/IndexedKeyMultimap.hpp
index a88f7251..68dc851f 100644
--- a/src/shamalgs/IndexedKeyMultimap.hpp
+++ b/src/shamalgs/IndexedKeyMultimap.hpp
@@ -8,28 +8,22 @@
 
 #pragma once
 
-#include "shambase/type_aliases.hpp"
 #include "shambase/sycl.hpp"
+#include "shambase/type_aliases.hpp"
 
 namespace shamalgs {
 
-
     class IndexedKeyMultimap {
 
         public:
-
         u32 unique_key_count;
         u32 pair_count;
 
         // [key_id_map[i] , key_id_map[i+1]] gives all the index in a key i
         std::unique_ptr<sycl::buffer<u32>> key_to_val;
 
-        // give the linked object 
+        // give the linked object
         std::unique_ptr<sycl::buffer<u32>> val_id_map;
-
-        
-
     };
 
-
-} // namespace shamalgs
\ No newline at end of file
+} // namespace shamalgs

@tdavidcl tdavidcl added Stalled and removed Draft labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algs] add IndexedKeyMultimap
1 participant