Skip to content

[SPH] move leapfrog integration to new module #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tdavidcl
Copy link
Member

No description provided.

Copy link

github-actions bot commented Apr 1, 2025

Workflow report

workflow report corresponding to commit 405adec
Commiter email is [email protected]

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report


/__w/Shamrock/Shamrock/src/shammodels/sph/src/modules/LeapfrogPredict.cpp:10:9: warning: #pragma once in main file [clang-diagnostic-pragma-once-outside-header]
   10 | #pragma once
      |         ^

4 warnings generated.
Suppressed 3 warnings (3 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Doxygen diff with main

Removed warnings : 12
New warnings : 24
Warnings count : 5694 → 5706 (0.2%)

Detailed changes :
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:28: warning: Compound shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:30: warning: Member Tscal (typedef) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:31: warning: Member dim (variable) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:32: warning: Member Kernel (typedef) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:34: warning: Member Config (typedef) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:35: warning: Member Storage (typedef) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:37: warning: Member RTree (typedef) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:39: warning: Member context (variable) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:40: warning: Member solver_config (variable) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:41: warning: Member storage (variable) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:43: warning: Member LeapfrogPredict(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::sph::modules::LeapfrogPredict is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/LeapfrogPredict.hpp:46: warning: Member do_predictor(Tscal dt) (function) of class shammodels::sph::modules::LeapfrogPredict is not documented.
- src/shammodels/sph/src/Solver.cpp:132: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/Solver.cpp:132: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:133: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:133: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/Solver.cpp:83: warning: Compound shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:84: warning: Compound shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:84: warning: Member Tscal (typedef) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:85: warning: Member Tscal (typedef) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:86: warning: Member nobj (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:87: warning: Member gpart_mass (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:87: warning: Member nobj (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:88: warning: Member gpart_mass (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:89: warning: Member buf_xyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:90: warning: Member buf_hpart (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:90: warning: Member buf_xyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:91: warning: Member buf_hpart (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:91: warning: Member buf_vxyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:92: warning: Member buf_vxyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:95: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/Solver.cpp:95: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:96: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:96: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.

@tdavidcl tdavidcl added the Draft label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant