Skip to content

[Ramses] Config for time integrators #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Ramses] Config for time integrators #927

wants to merge 2 commits into from

Conversation

Akos299
Copy link
Collaborator

@Akos299 Akos299 commented Apr 22, 2025 

  -------I. **Unsplit schemes** --------
	1. 2rd order MUSCL


------II. **Semi discrete schemes** -------
        1. RK1
	3. RK2-SSP
	4. RK3-SSP
	5. VL2

@Akos299
Add config for time integrators
c03a127 
      -------I. Unsplit schemes --------
		1. 2rd order MUSCL
      ------II. Semi discrete schemes -------
	        1. RK1
		2. RK2-SSP
		3. RK3-SSP
		4. VL2
@Akos299 Akos299 requested a review from tdavidcl April 22, 2025 12:03
@tdavidcl tdavidcl added the Draft label Apr 22, 2025
@github-actions GitHub Actions
Copy link

Workflow report

workflow report corresponding to commit 92a3915
Commiter email is [email protected]

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 58
New warnings : 60
Warnings count : 5733 → 5735 (0.0%)

Detailed changes : 
- src/shamcomm/include/shamcomm/mpiInfo.hpp:51: warning: Member is_direct_comm_aware(const StateMPI_Aware &v) (function) of namespace shamcomm is not documented.
- src/shamcomm/include/shamcomm/mpiInfo.hpp:51: warning: Member is_direct_comm_aware(const StateMPI_Aware &v) (function) of namespace shamcomm is not documented.
- src/shamcomm/src/mpiInfo.cpp:67: warning: Member _forced_state (variable) of namespace shamcomm is not documented.
- src/shamcomm/src/mpiInfo.cpp:67: warning: Member _forced_state (variable) of namespace shamcomm is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:101: warning: Member set_refine_none() (function) of struct shammodels::basegodunov::AMRMode is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:102: warning: Compound shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:102: warning: Member set_refine_density_based(Tscal crit_mass) (function) of struct shammodels::basegodunov::AMRMode is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:104: warning: Member Tscal (typedef) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:106: warning: Compound shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:107: warning: Compound shammodels::basegodunov::AMRMode::DensityBased is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:108: warning: Member Tscal (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:108: warning: Member crit_mass (variable) of struct shammodels::basegodunov::AMRMode::DensityBased is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:110: warning: Member eos_gamma (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:111: warning: Member mode (typedef) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:112: warning: Member grid_coord_to_pos_fact (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:113: warning: Member config (variable) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:114: warning: Member NsideBlockPow (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:115: warning: Member AMRBlock (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:115: warning: Member set_refine_none() (function) of struct shammodels::basegodunov::AMRMode is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:116: warning: Member set_refine_density_based(Tscal crit_mass) (function) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:117: warning: Member set_eos_gamma(Tscal gamma) (function) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:119: warning: Member riemman_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:120: warning: Compound shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:120: warning: Member slope_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:121: warning: Member face_half_time_interpolation (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:122: warning: Member Tscal (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:122: warning: Member dust_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:123: warning: Member drag_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:124: warning: Member eos_gamma (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:125: warning: Member is_dust_on() (function) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:126: warning: Member grid_coord_to_pos_fact (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:128: warning: Member NsideBlockPow (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:128: warning: Member set_alphas_static(f32 alpha_values) (function) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:129: warning: Member AMRBlock (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:131: warning: Member set_eos_gamma(Tscal gamma) (function) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:133: warning: Member Csafe (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:133: warning: Member riemman_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:134: warning: Member slope_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:135: warning: Member face_half_time_interpolation (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:136: warning: Member dust_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:137: warning: Member drag_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:138: warning: Member time_integrator_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:139: warning: Member is_muscl_scheme() (function) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:141: warning: Member is_dust_on() (function) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:144: warning: Member set_alphas_static(f32 alpha_values) (function) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:149: warning: Member Csafe (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:153: warning: Compound shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:155: warning: Member Tscal (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:156: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:157: warning: Member dim (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:159: warning: Member u_morton (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:160: warning: Member Config (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:162: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:164: warning: Member context (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:165: warning: Member scheduler() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:167: warning: Member solver_config (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:169: warning: Compound shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:169: warning: Member storage (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:171: warning: Member Tscal (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:171: warning: Member init_required_fields() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:172: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:173: warning: Member dim (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:175: warning: Member u_morton (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:176: warning: Member Config (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:178: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:180: warning: Member context (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:181: warning: Member scheduler() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:183: warning: Member solver_config (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:185: warning: Member storage (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:186: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:187: warning: Member init_required_fields() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:188: warning: Member do_debug_vtk_dump(std::string filename) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:190: warning: Member print_timestep_logs() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:199: warning: Member evolve_once() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:201: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:202: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:204: warning: Member do_debug_vtk_dump(std::string filename) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:206: warning: Member print_timestep_logs() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:208: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:215: warning: Member evolve_once() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:217: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:224: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:37: warning: Member DustRiemannSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:37: warning: Member DustRiemannSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:37: warning: Member TimeIntegratorMode (enumeration) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:37: warning: Member TimeIntegratorMode (enumeration) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:39: warning: Member DustRiemannSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:39: warning: Member DustRiemannSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:43: warning: Member DragSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:43: warning: Member DragSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:45: warning: Member DragSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:45: warning: Member DragSolverMode (enumeration) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:54: warning: Member drag_solver_config (variable) of struct shammodels::basegodunov::DragConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:55: warning: Member alphas (variable) of struct shammodels::basegodunov::DragConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:56: warning: Member enable_frictional_heating (variable) of struct shammodels::basegodunov::DragConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:56: warning: Member time_integrator_config (variable) of struct shammodels::basegodunov::TimeIntegratorConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:57: warning: Member is_muscl_scheme() (function) of struct shammodels::basegodunov::TimeIntegratorConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:60: warning: Compound shammodels::basegodunov::DustConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:61: warning: Member dust_riemann_config (variable) of struct shammodels::basegodunov::DustConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:62: warning: Member ndust (variable) of struct shammodels::basegodunov::DustConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:64: warning: Member is_dust_on() (function) of struct shammodels::basegodunov::DustConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:68: warning: Member drag_solver_config (variable) of struct shammodels::basegodunov::DragConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:69: warning: Member alphas (variable) of struct shammodels::basegodunov::DragConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:70: warning: Member enable_frictional_heating (variable) of struct shammodels::basegodunov::DragConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:74: warning: Compound shammodels::basegodunov::DustConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:75: warning: Member dust_riemann_config (variable) of struct shammodels::basegodunov::DustConfig is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:76: warning: Member ndust (variable) of struct shammodels::basegodunov::DustConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:78: warning: Compound shammodels::basegodunov::SolverStatusVar is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:78: warning: Member is_dust_on() (function) of struct shammodels::basegodunov::DustConfig is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:88: warning: Compound shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:90: warning: Member Tscal (typedef) of struct shammodels::basegodunov::AMRMode is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:92: warning: Compound shammodels::basegodunov::SolverStatusVar is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:93: warning: Compound shammodels::basegodunov::AMRMode::DensityBased is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:94: warning: Member crit_mass (variable) of struct shammodels::basegodunov::AMRMode::DensityBased is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:97: warning: Member mode (typedef) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:99: warning: Member config (variable) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:244: warning: Member Register_pymod(pybasegodunovmodel) (function) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:268: warning: Member Register_pymod(pybasegodunovmodel) (function) of file pyRamsesModel.cpp is not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdavidcl tdavidcl Awaiting requested review from tdavidcl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akos299 @tdavidcl