Skip to content

[Snyk] Fix for 2 vulnerabilities #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shaun-Adams wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions angular-todo/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions angular-todo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"dependencies": {
"@angular/animations": "~13.3.0",
"@angular/cdk": "^13.3.9",
"@angular/common": "~13.3.0",
"@angular/compiler": "~13.3.0",
"@angular/common": "~19.2.16",
"@angular/compiler": "~19.2.17",
Comment on lines +15 to +16

Copilot AI Dec 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical peer dependency mismatch: Upgrading only @angular/common and @angular/compiler to version 19 while keeping all other Angular packages at version 13 will break the application.

@angular/common@19.2.16 has a peer dependency requirement of @angular/core@19.2.16, but @angular/core remains at ~13.3.0 (line 17). Similarly, other Angular packages like @angular/animations, @angular/forms, @angular/material, etc. all have peer dependencies on Angular 13 versions and will be incompatible with Angular 19 packages.

To properly fix the security vulnerabilities, you need to:

  1. Upgrade ALL Angular packages to version 19 (including @angular/core, @angular/animations, @angular/forms, @angular/material, @angular/platform-browser, @angular/platform-browser-dynamic, @angular/router)
  2. Update dev dependencies (@angular-devkit/build-angular, @angular/cli, @angular/compiler-cli) to compatible version 19 packages
  3. Verify TypeScript compatibility (Angular 19 requires TypeScript 5.x, but the project currently uses TypeScript ~4.6.2)
  4. Review and update RxJS and zone.js if needed
  5. Address any breaking changes between Angular 13 and Angular 19 (this is a major version upgrade spanning 6 major versions)

Copilot uses AI. Check for mistakes.
"@angular/core": "~13.3.0",
"@angular/forms": "~13.3.0",
"@angular/material": "^13.3.9",
Expand Down