Implement rudimentary regex voidlist support #110
+353
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone ahead and implemented a rudimentary version of what was requested on #109 - I believe some work is still necessary here and I'm willing to do it, though I'd love some guidance.
The goal is to have a separate VoidList for just regex patterns, you can add as many as you want. I also added an offworld toggle to only apply the regex block to offworld characters (this could help preventing accidental matches).
My implementation seems to work just fine though I haven't quite figured out how to force a refresh properly so usability is a bit confusing at the moment. When disabling a regex, blocked characters don't get re-rendered until you walk away and walk back to them, this might be a game limitation though?
I also think maybe incorporating a whitelist check might be a good idea.. If a character matches a regex but is whitelisted it might be wise to allow that?
Let me know what changes you want and I'd be happy to make them! I tried my best to keep performance reasonable given the nature of the operation.