Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Shimmer3R USB identification and serial-port control-line defaults to improve compatibility with S3R USBX-based connections.
Changes:
- Enable DTR by default when opening/configuring JSSC serial ports.
- Update Shimmer3R serial-port USB hardware ID to the USBX driver PID and remove unused Shimmer3R MSC/composite device string constants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ShimmerDriverPC/src/main/java/com/shimmerresearch/pcSerialPort/SerialPortCommJssc.java |
Changes default DTR-on-connect behavior for all JSSC serial connections. |
ShimmerDriver/src/main/java/com/shimmerresearch/driverUtilities/HwDriverShimmerDeviceDetails.java |
Updates Shimmer3R serial-port VID/PID matching for USBX drivers and removes unused legacy constants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShimmerDriverPC/src/main/java/com/shimmerresearch/pcSerialPort/SerialPortCommJssc.java
Outdated
Show resolved
Hide resolved
JongChern
approved these changes
Mar 25, 2026
Collaborator
JongChern
left a comment
JongChern
left a comment
There was a problem hiding this comment.
looks good and tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.