Skip to content

FairShip: Find python paths correctly #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olantwin merged 1 commit into from
Sep 26, 2025
Merged

FairShip: Find python paths correctly #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Until May 2022 (inclusive) no changelog was kept. We might try to reconstruct it
* FairRoot: Add missing GEANT3 dependency
* EvtGen: Fix detection of C++11
* ACTS/Eigen3/Hepmc3: Fixed module detection
* FairShip: Find python paths correctly

### Changed

Expand Down
4 changes: 2 additions & 2 deletions fairship.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@
-DHEPMC_INCLUDE_DIR=$HEPMC_ROOT/include/HepMC \
-DEVTGEN_INCLUDE_DIR=$EVTGEN_ROOT/include \
-DEVTGEN_LIBRARY_DIR=$EVTGEN_ROOT/lib \
${PYTHON_ROOT:+-DPYTHON_LIBRARY=$PYTHON_ROOT/lib} \
${PYTHON_ROOT:+-DPYTHON_INCLUDE_DIR=$PYTHON_ROOT/include/python3.6m/} \
-DPYTHON_INCLUDE_DIR=$(python -c "import sysconfig; print(sysconfig.get_path('include'))") \

Check warning on line 99 in fairship.sh

View workflow job for this annotation

GitHub Actions / alidistlint 

Quote this to prevent word splitting. [SC2046]
-DPYTHON_LIBRARY=$(python -c "import sysconfig; print(sysconfig.get_config_var('LIBDIR'))") \

Check warning on line 100 in fairship.sh

View workflow job for this annotation

GitHub Actions / alidistlint 

Quote this to prevent word splitting. [SC2046]
-DPYTHIA8_DIR=$PYTHIA_ROOT \
-DPYTHIA8_INCLUDE_DIR=$PYTHIA_ROOT/include \
-DGEANT4_ROOT=$GEANT4_ROOT \
Expand Down