Open
Conversation
…ompanies/{slug}/posts
- Add GET /posts/{id} endpoint for fetching single review
- Add GET /companies/{slug}/posts endpoint for company-scoped feed
- Implement cursor pagination with limit, since, until, tag, status filters
- Add text sanitization for public responses
- Add proper error handling (410 Gone for soft-deleted, 404 for non-existent)
- Add DB composite indexes for performance
- Add tests for single fetch and company feed pagination
- Update route parameter syntax from :id to {id} for Axum v0.7 compatibility
- Fix SQL query in list_company_reviews to properly handle deleted reviews
- Update test assertions in reviews_test.rs:
- Fix test_get_review_by_id to use correct ID
- Fix test_text_sanitization to handle HTML content
- Fix test_list_company_reviews to match actual behavior
TropicalDog17
requested review from
PoulavBhowmick03,
guha-rahul and
tosoham
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@TropicalDog17 the Anon CICD is failing, please check |
Contributor
|
@TropicalDog17 updates? |
…kFinder into feat/review-read-apis
Author
|
Can you help me with the issue, no idea why ci fail here, local work fine for me |
Contributor
PoulavBhowmick03
left a comment
PoulavBhowmick03
left a comment
There was a problem hiding this comment.
can you also update the API docs in swagger, apart from lint and build passing
…d company-specific review listing - Add /posts/:id endpoint to get reviews by ID with 410 for deleted reviews - Add /companies/:slug/posts endpoint to list company reviews with filtering - Implement text sanitization for review content - Update tests with proper BigDecimal parsing and fix race conditions - Regenerate SQLx query cache for new review endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Description
Description
Please include a summary of the change and which issue is fixed (if any). Please also include relevant motivation and context. List any dependencies that are required for this change.
🔗 Linked Issues
Fixes #559
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
📸 Screenshots
[Include relevant screenshots or screen recordings demonstrating the changes]
✅ PR Checklist