Cleanup Publish Workflow #459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables creating pre-release tags from any branch with configurable version numbers and types (alpha/beta/rc), with dry-run support for safe testing before publishing.
1. Rename `deploy.yml` to `publish.yml` for GH Actions to match other kit libraries 2. Update title 3. Add version validation 4. Update docs
westeezy
changed the title
westeezy
commented
Nov 11, 2025
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
|
|
||
| - name: Validate versions match |
Author
There was a problem hiding this comment.
The only difference here is this validate task
kiftio
approved these changes
Nov 21, 2025
kiftio
reviewed
Nov 21, 2025
| run: | | ||
| PODSPEC_VERSION=$(grep -E "s.version\s*=\s*" ShopifyCheckoutSheetKit.podspec | sed -E 's/.*"([^"]+)".*/\1/') | ||
| SWIFT_VERSION=$(grep -E "public let version = " Sources/ShopifyCheckoutSheetKit/ShopifyCheckoutSheetKit.swift | sed -E 's/.*"([^"]+)".*/\1/') | ||
| GIT_TAG="${{ github.event.release.tag_name }}" |
Contributor
There was a problem hiding this comment.
We could be very defensive against failing to extract these vars, and do something like
if [ -z "$PODSPEC_VERSION" ]; then
echo "Error: Could not extract version from ShopifyCheckoutSheetKit.podspec"
echo "Expected format: s.version = \"X.Y.Z\""
exit 1
fi
if [ -z "$SWIFT_VERSION" ]; then
echo "Error: Could not extract version from ShopifyCheckoutSheetKit.swift"
echo "Expected format: public let version = \"X.Y.Z\""
exit 1
fiBut feels alright as it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
deploy.ymltopublish.ymlfor GH Actions to match otherkit libraries
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.