-
Notifications
You must be signed in to change notification settings - Fork 220
If --id is not provided to shopify app bulk status, show all bulk operations
#6668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If --id is not provided to shopify app bulk status, show all bulk operations
#6668
Conversation
shopify app bulk status, show all bulk operations--id is not provided to shopify app bulk status, show all bulk operations
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3448 tests passing in 1396 suites. Report generated by 🧪jest coverage report action from be16198 |
1b17a01 to
de15a6b
Compare
47deba6 to
ba766c2
Compare
16085c8 to
d855b62
Compare
ba766c2 to
06c54d9
Compare
d855b62 to
15e649b
Compare
06c54d9 to
f23864f
Compare
15e649b to
80235a5
Compare
f23864f to
49dc53d
Compare
80235a5 to
04cb306
Compare
49dc53d to
23dbbb9
Compare
04cb306 to
3faa882
Compare
586357c to
168f42f
Compare
33a2e16 to
3dc60f0
Compare
168f42f to
f6b7dd0
Compare
3dc60f0 to
1220b22
Compare
f6b7dd0 to
156dbef
Compare
1220b22 to
8e4cd3b
Compare
156dbef to
739db4d
Compare
8e4cd3b to
761e22f
Compare
739db4d to
d924028
Compare
cc1db6c to
bce54f6
Compare
c542ecf to
3eaa19f
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/string.d.ts@@ -120,4 +120,12 @@ export declare function pascalize(str: string): string;
* @param delimiter - Delimiter used to split the string into tokens.
* @returns String with the normalized list of tokens.
*/
-export declare function normalizeDelimitedString(delimitedString?: string, delimiter?: string): string | undefined;
\ No newline at end of file
+export declare function normalizeDelimitedString(delimitedString?: string, delimiter?: string): string | undefined;
+/**
+ * Given two dates, it returns a human-readable string representing the time elapsed between them.
+ *
+ * @param from - Start date.
+ * @param to - End date.
+ * @returns A string like "5 minutes ago" or "2 days ago".
+ */
+export declare function timeAgo(from: Date, to: Date): string;
\ No newline at end of file
|
a25cc11 to
4907f19
Compare
4907f19 to
dfd44d7
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running just |
gonzaloriestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3615084 to
2fa7198
Compare
|
Great feedback, thanks Gonzalo :) I made the description and newline changes. I kept the IDs as GIDs for now, but logged it as a minor polish item (https://github.com/shop/issues-api-foundations/issues/1149) for Nick to look at and make a decision. Thanks for the thoughtful review as always! |
Co-authored-by: Gonzalo Riestra <[email protected]>
2fa7198 to
be16198
Compare
I think to save room this is OK in the table, but only if the |


WHY are these changes introduced?
Part 2/2 addressing https://github.com/shop/issues-api-foundations/issues/1142.
WHAT is this pull request doing?
Introduces new behaviour to
shopify app bulk statusto list all bulk operations from the last 7 days if--idis not provided.How to test your changes?
Try running:
You should see either an info banner telling you there are no operations found, or a table displaying info about your bulk operations if there were some:
(Note that we're in the midst of refactoring some access token issues on the backend, so you might not actually be able to see bulk operations created in the past because they were created with a different access token. This is unrelated to this PR and will be fixed soon. See https://docs.google.com/document/d/11oPgFRyJDYkHwv7zPVPGErG3vfDuGkhJKmICgTSYCcc/edit?tab=t.0)