Skip to content

Execute rack.response_finished callbacks in reverse order of registration #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
casperisfine merged 1 commit into from
Jul 16, 2025
Merged

Execute rack.response_finished callbacks in reverse order of registration #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Fix a regression introduced in `0.17.0` causing `before_worker_exit` to often not be called.
- Implemented the `max_consecutive_spawn_errors` configuration. Purely opt-in for now.
- Properly handle magic comments in `config.ru`.
- Execute `rack.response_finished` callbacks in reverse order of registration

# 0.17.0

Expand Down
2 changes: 1 addition & 1 deletion lib/pitchfork/http_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ def process_client(client, worker, timeout_handler)
env
ensure
if env
env["rack.response_finished"].each do |callback|
env["rack.response_finished"].reverse_each do |callback|
if callback.arity == 0
callback.call
else
Expand Down
Loading