Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Add shared ignore list for server and subscriber #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Owen-Cummings
Copy link
Member

Allows an ignore list for extensions we don't wish to vouch from the configuration file.

Copy link

@chrisshino chrisshino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

@thepwagner thepwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, noting the things we want to verify from our pairing session:

  • We assume imageData.String() is the full registry+label (e.g. gcr.io/my-project/my-image:my-tag)
  • We assume returning an empty HTTP body won't affect clients, if they get a 200 OK they are happy.

We could consider integrating this with the metrics system, but lets not - the logging signal should be sufficient that we can see it working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants