Pass in host address when creating contract for refresh/renewal#397
Merged
Pass in host address when creating contract for refresh/renewal#397
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the RHP v4 contract renewal/refresh constructors to require an explicit host wallet address, ensuring the new contract’s host output is set to the caller-provided address (instead of implicitly inheriting the old one).
Changes:
- Add
hostAddress types.Addressparameter toRenewContract,RefreshContractPartialRollover, andRefreshContractFullRollover, and apply it toNewContract.HostOutput.Address. - Update v4 RHP cost tests to pass distinct “old” vs “new” host addresses and assert the new contract pays the new address.
- Add a knope changeset documenting the breaking change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
rhp/v4/rhp.go |
Extends renewal/refresh constructors to accept and set the host payout address on the newly created contract. |
rhp/v4/rhp_test.go |
Updates tests for the new function signatures and adds assertions that the new contract uses the provided host address. |
.changeset/require_passing_hosts_wallet_address_when_constructing_a_contract_for_renewalrefresh.md |
Documents the breaking API change for release/versioning via knope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6ff3b99 to
bf0d111
Compare
peterjan
requested changes
Apr 21, 2026
peterjan
approved these changes
Apr 21, 2026
n8mgr
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.