Skip to content

Pass in host address when creating contract for refresh/renewal#397

Merged
n8mgr merged 2 commits intomasterfrom
chris/fix-address-renewal
Apr 21, 2026
Merged

Pass in host address when creating contract for refresh/renewal#397
n8mgr merged 2 commits intomasterfrom
chris/fix-address-renewal

Conversation

@ChrisSchinnerl
Copy link
Copy Markdown
Member

No description provided.

@ChrisSchinnerl ChrisSchinnerl self-assigned this Apr 21, 2026
Copilot AI review requested due to automatic review settings April 21, 2026 08:59
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the RHP v4 contract renewal/refresh constructors to require an explicit host wallet address, ensuring the new contract’s host output is set to the caller-provided address (instead of implicitly inheriting the old one).

Changes:

  • Add hostAddress types.Address parameter to RenewContract, RefreshContractPartialRollover, and RefreshContractFullRollover, and apply it to NewContract.HostOutput.Address.
  • Update v4 RHP cost tests to pass distinct “old” vs “new” host addresses and assert the new contract pays the new address.
  • Add a knope changeset documenting the breaking change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
rhp/v4/rhp.go Extends renewal/refresh constructors to accept and set the host payout address on the newly created contract.
rhp/v4/rhp_test.go Updates tests for the new function signatures and adds assertions that the new contract uses the provided host address.
.changeset/require_passing_hosts_wallet_address_when_constructing_a_contract_for_renewalrefresh.md Documents the breaking API change for release/versioning via knope.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rhp/v4/rhp_test.go Outdated
Comment thread rhp/v4/rhp_test.go Outdated
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan April 21, 2026 11:18
@n8mgr n8mgr merged commit 3a5d3f2 into master Apr 21, 2026
13 checks passed
@n8mgr n8mgr deleted the chris/fix-address-renewal branch April 21, 2026 13:19
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sia Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants