Skip to content

Don't consider hosts on "bad" QUIC ports usable#943

Merged
n8mgr merged 4 commits intomasterfrom
christopher/block-bad-ports
Apr 21, 2026
Merged

Don't consider hosts on "bad" QUIC ports usable#943
n8mgr merged 4 commits intomasterfrom
christopher/block-bad-ports

Conversation

@chris124567
Copy link
Copy Markdown
Member

Close #941

Copilot AI review requested due to automatic review settings April 16, 2026 19:07
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures hosts advertising QUIC endpoints on browser-blocked ports are treated as unreachable/unhealthy for QUIC/WebTransport use cases (closes #941), by filtering such addresses at ingestion time and cleaning up existing stored addresses.

Changes:

  • Add a browser-blocked QUIC port set and reject QUIC announcements on those ports during host announcement validation.
  • Add a Postgres migration to delete existing QUIC host_addresses entries on blocked ports.
  • Extend host manager tests to cover blocked-port QUIC announcements (drop QUIC-only host; keep siamux when mixed).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
persist/postgres/migrations.go Adds a migration deleting stored QUIC addresses that use browser-blocked ports.
hosts/manager.go Introduces badQUICPorts and updates validateAddress to reject QUIC addresses on blocked ports.
hosts/manager_test.go Adds test cases verifying blocked-port QUIC announcements are ignored/dropped as intended.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread hosts/manager.go Outdated
Comment thread hosts/manager.go Outdated
Comment thread persist/postgres/migrations.go Outdated
Comment thread persist/postgres/migrations.go Outdated
peterjan
peterjan previously approved these changes Apr 17, 2026
Comment thread hosts/manager.go Outdated
n8mgr
n8mgr previously approved these changes Apr 19, 2026
peterjan
peterjan previously approved these changes Apr 20, 2026
Comment thread .changeset/dont_consider_hosts_on_bad_quic_ports_usable.md
@chris124567 chris124567 dismissed stale reviews from peterjan and n8mgr via a13784c April 20, 2026 17:05
n8mgr
n8mgr previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@n8mgr n8mgr merged commit aa5236e into master Apr 21, 2026
12 checks passed
@n8mgr n8mgr deleted the christopher/block-bad-ports branch April 21, 2026 07:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Don't consider hosts on "bad" QUIC ports usable

5 participants