Conversation
peterjan
commented
Apr 21, 2026
6b60ed9 to
39502e1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI and some filesystem handling to enable running the Go test suite across platforms (Windows/macOS/Linux), addressing platform-specific file deletion semantics and test resource cleanup.
Changes:
- Switch CI to a shared reusable Go test workflow (intended to run on multiple OSes) and enable CGO for sqlite.
- Add OS-specific
openFileAllowDeleteto allow reading files while they may be deleted on Windows; update upload reads to use it. - Improve sqlite test/benchmark cleanup by closing the database store; remove multipart parent-directory sync calls.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
sia/persist/sqlite/objects_test.go |
Adds Cleanup hooks to close sqlite store after tests/benchmarks. |
sia/open_file_windows.go |
Windows-specific file open allowing delete sharing via CreateFile. |
sia/open_file_nonwindows.go |
Non-Windows implementation using os.Open. |
sia/objects.go |
Uses openFileAllowDelete when reading an upload file. |
sia/multipart.go |
Removes parent-directory sync step after writing multipart parts. |
.github/workflows/go-test.yml |
Replaces in-repo steps with a reusable workflow call; adds push trigger and sets CGO_ENABLED. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130