Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes object-part retrieval so that part-based GET/HEAD requests can correctly serve data for both regular and multipart objects, including cases where the data must be read from disk or from Sia.
Changes:
- Adjust SQLite object retrieval to validate part numbers correctly for non-multipart objects and to include additional object fields when querying a specific part.
- Update Sia backend part responses to return a correct
PartsCountfor non-multipart objects when apartNumberis specified. - Add regression tests covering non-multipart objects requested with a part number.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sia/persist/sqlite/objects_test.go | Extends DB-level coverage for part-number fetches, including ensuring SiaObject is returned. |
| sia/persist/sqlite/objects.go | Fixes part-number logic and expands the part query to include fields needed to serve from disk/Sia. |
| sia/objects.go | Adjusts PartsCount returned for part-number GET/HEAD on non-multipart objects. |
| s3/objects_test.go | Adds regression test for part-number requests on non-multipart objects. |
| .gitignore | Ignores GeoLite2 DB file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When retrieving an object by part number, the parts count was incorrectly returned as 0 for non-multipart objects, and the part query was missing filename, sia_object, and cached_at fields which prevented serving part data from disk or Sia.