This repository was archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] Fix spawning multiple pirate ships and refactor comms console answer keys#1433
Open
SinguloBot wants to merge 2 commits into
Open
[MIRROR] Fix spawning multiple pirate ships and refactor comms console answer keys#1433SinguloBot wants to merge 2 commits into
SinguloBot wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#7608
About The Pull Request
[issue link stripped]
Also refactors comms console messages to use string keys instead of numbers, that way you can use DEFINES. Changes the pirate responses to use DEFINES.
Why It's Good For The Game
Having multiple pirate ships is bad
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
fix: Pirates event no longer spawns two pirate ships.
refactor: Comms console message responses now use string keys so that DEFINES can be used.
/:cl: