Skip to content

Remove confusion AbstractDSLLaunchConfigurationDelegateUI classes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ebousse
Copy link
Contributor

@ebousse ebousse commented Jul 17, 2017

To better distinguish the classes

org.eclipse.gemoc.dsl.debug.ide.sirius.ui.launch.AbstractDSLLaunchConfigurationDelegateUI

and

org.eclipse.gemoc.dsl.debug.ide.ui.launch.AbstractDSLLaunchConfigurationDelegateUI

this commit renames the former to AbstractDSLLaunchConfigurationDelegateUI2

For some reason, this caused me really strange compilation errors in Eclipse, while probably tycho is not bothered.

To better distinguish the classes

org.eclipse.gemoc.dsl.debug.ide.sirius.ui.launch
.AbstractDSLLaunchConfigurationDelegateUI

and

org.eclipse.gemoc.dsl.debug.ide.ui.launch
.AbstractDSLLaunchConfigurationDelegateUI

this commit renames the former to
AbstractDSLLaunchConfigurationDelegateUI2

For some reason, this caused me really strange compilation
errors in Eclipse, while probably tycho is not bothered.
@ylussaud
Copy link
Contributor

Please not AbstractDSLLaunchConfigurationDelegateUI2... let say org.eclipse.gemoc.dsl.debug.ide.sirius.ui.launch.AbstractDSLLaunchConfigurationDelegateSiriusUI

If it's ok with you ? I know it's a bit long but meaningful.

@ebousse
Copy link
Contributor Author

ebousse commented Jul 18, 2017

That's perfectly OK for me! I was not very inspired for the new name :)

I'll refactor the PR later today then.

@ylussaud
Copy link
Contributor

thanks a lot

@dvojtise
Copy link
Contributor

dvojtise commented Sep 5, 2017

with the transfer of the code to the Eclipse foundation (see gemoc@eclipse), this repository is now deprecated and replaced by https://github.com/eclipse/gemoc-studio-modeldebugging/

Since only the master branch was transfered, this pull request was not taken into account.

Please consider contributing/adapting this pull request to the new official repository https://github.com/eclipse/gemoc-studio-modeldebugging/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants