Skip to content

Use the gradle properties for the latest environment reference #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev/feature
Choose a base branch
from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Apr 13, 2025

Description

Use the gradle properties for the latest environment reference so you don't have to remember to maintain it each version bump.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner April 13, 2025 09:34
@TheLimeGlass TheLimeGlass requested review from sovdeeth and Romitou and removed request for a team April 13, 2025 09:34
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also adjust line 269 as well

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 16, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 15, 2025
@TheLimeGlass
Copy link
Contributor Author

should also adjust line 269 as well

To what? It's already referencing the file?

@TheLimeGlass TheLimeGlass requested a review from sovdeeth July 1, 2025 01:32
@sovdeeth
Copy link
Member

sovdeeth commented Jul 1, 2025

This change makes env identical to latestEnv, so env should be removed and references replaced with latestEnv
Actually latestEnv is not necessarily the latest anymore, so it should just replace env directly.

String env = project.testEnv + ".json";

@TheLimeGlass
Copy link
Contributor Author

This change makes env identical to latestEnv, so env should be removed and references replaced with latestEnv Actually latestEnv is not necessarily the latest anymore, so it should just replace env directly.

String env = project.testEnv + ".json";

Okay, I see what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. needs reviews A PR that needs additional reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants