Support for the SyntaxInfo suppliers #8124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gacy api, replaced reflection calls for creating instances of syntax infos with LambdaMetafactory
skriptlang-automation
bot
added
the
needs reviews
…ch/syntaxinfo-supply # Conflicts: # src/main/java/ch/njol/skript/lang/SkriptParser.java # src/main/java/ch/njol/skript/lang/SyntaxElementInfo.java
skriptlang-automation
bot
removed
the
needs reviews
skriptlang-automation
bot
added
the
needs reviews
Pesekjak
added
the
enhancement
Efnilite
requested changes
Aug 11, 2025
Co-authored-by: Efnilite <[email protected]>
Co-authored-by: Efnilite <[email protected]>
Co-authored-by: Efnilite <[email protected]>
APickledWalrus
requested changes
Aug 11, 2025
| return supplier == null ? type.getDeclaredConstructor().newInstance() : supplier.get(); | ||
| } catch (ReflectiveOperationException e) { | ||
| throw new RuntimeException(e); | ||
| if (supplier == null) { |
There was a problem hiding this comment.
I think it'd be fine to set the supplier when the object is constructed so that the field can continue to be final.
There was a problem hiding this comment.
I think creating a lot of metafactories can get fairly expensive so I wanted to initialize them lazily. I'll check the performance cost during startup and see how bad it gets.
| @@ -16,4 +23,36 @@ public static boolean isNormalClass(Class<?> clazz) { | |||
| && !clazz.isInterface() && !Modifier.isAbstract(clazz.getModifiers()); | |||
| } | |||
|
|
|||
| private static final Map<Class<?>, Supplier<?>> instanceSuppliers = new ConcurrentHashMap<>(); | |||
There was a problem hiding this comment.
Do you think a cache is necessary? The method would probably only be called once per registered syntax, right?
skriptlang-automation
bot
removed
the
needs reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The syntax info suppliers developers can provide in the new API are lost during the conversion to SyntaxElementInfo.
Solution
SyntaxElementInfo now stores its instance supplier. If none is provided, it uses the nullary constructor instead.
I also replaced repeated reflection calls with Supplier created using LambdaMetafactory that delegates to the nullary constructor.
Testing Completed
quick test
Completes: none
Related: none