Skip to content

Bugfix - Service created from order inherits category icon from the order item #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruicamacho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix - Service created from order inherits category icon from the order item #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions SLC_SM_Create Service Inventory Item/SLC_SM_Create Service Inventory Item.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,22 @@ public void Run(IEngine engine)

private static Guid CreateServiceItemFromOrderItem(DataHelpersServiceManagement repo, Models.ServiceOrderItem serviceOrderItem)
{
var category = serviceOrderItem.ServiceCategoryId.HasValue ?
repo.ServiceCategories
.Read(ServiceCategoryExposers.Guid.Equal(serviceOrderItem.ServiceCategoryId.Value))
.FirstOrDefault()
: null;

Models.Service newService = new Models.Service
{
ServiceID = repo.Services.UniqueServiceId(),
Name = serviceOrderItem.Name,
Description = serviceOrderItem.Name,
StartTime = serviceOrderItem.StartTime,
EndTime = serviceOrderItem.EndTime,
Icon = String.Empty,
ServiceSpecificationId = serviceOrderItem.SpecificationId,
Category = serviceOrderItem.ServiceCategoryId.HasValue ? repo.ServiceCategories.Read(ServiceCategoryExposers.Guid.Equal(serviceOrderItem.ServiceCategoryId.Value)).FirstOrDefault() : null,
Category = category,
Icon = category?.Icon ?? string.Empty,
ServiceItems = new List<Models.ServiceItem>(),
ServiceItemsRelationships = new List<Models.ServiceItemRelationShip>(),
ServiceConfiguration = new Models.ServiceConfigurationVersion
Expand Down Expand Up @@ -183,7 +189,6 @@ private static Guid CreateServiceItemFromOrderItem(DataHelpersServiceManagement
var spec = serviceOrderItem.SpecificationId.HasValue ? repo.ServiceSpecifications.Read(ServiceSpecificationExposers.Guid.Equal(serviceOrderItem.SpecificationId.Value)).FirstOrDefault() : null;
if (spec != null)
{
newService.Icon = spec.Icon;
if (spec.ServiceItemsRelationships != null)
{
foreach (var relationship in spec.ServiceItemsRelationships)
Expand Down