Bump androidx.compose:compose-bom from 2025.04.00 to 2025.05.00 #2273

dependabot · 2025-04-24T10:18:38Z

Bumps androidx.compose:compose-bom from 2025.04.00 to 2025.04.01.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot · 2025-05-08T10:44:20Z

A newer version of androidx.compose:compose-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

LokmaneKrizou · 2025-05-12T07:57:24Z

ticket created
https://skyscanner.atlassian.net/browse/DON-1614

skyscanner-backpack-bot · 2025-05-19T13:57:54Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 58f8445

skyscanner-backpack-bot · 2025-05-19T14:49:17Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 66f01c4

skyscanner-backpack-bot · 2025-05-19T15:57:22Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 414af06

skyscanner-backpack-bot · 2025-05-19T16:20:44Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against f0a71ec

LokmaneKrizou · 2025-05-20T08:14:18Z

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/utils/DeviceUtil.kt

 import androidx.compose.runtime.Composable
 import androidx.compose.ui.platform.LocalConfiguration

+@SuppressLint("ConfigurationScreenWidthHeight")


never add a SupressLint as a solution, this should be a last resort, instead we should check whats the correct way to fix this by reading the lint error message, if u can share it here so we can check it, it would be great!

This is the error after bumping the version. I tried using LocalWindowInfo.current.containerSize, However, it would change some text size for some reason. I was planning to create another ticket for more inverstigation on it and having suppress lint as a temporart solution for now

can u share the text size issue here please?

Copilot

Pull Request Overview

This PR upgrades the Compose BOM version and adds lint suppressions for configuration checks in specific Compose utility and component files.

Bumps androidx.compose:compose-bom from 2025.04.00 to 2025.05.00
Adds @SuppressLint("ConfigurationScreenWidthHeight") annotations to composable helpers and notifications to silence lint warnings

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

File	Description
gradle/libs.versions.toml	Updated `compose-bom` version to 2025.05.00
backpack-compose/src/main/kotlin/.../DeviceUtil.kt	Imported and applied lint suppression on device‐detection utils
backpack-compose/src/main/kotlin/.../BpkFloatingNotification.kt	Imported and applied lint suppression on floating notification

Copilot · 2025-05-20T08:15:45Z

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/utils/DeviceUtil.kt

+@SuppressLint("ConfigurationScreenWidthHeight")
 @Composable
 internal fun isSmallTablet(): Boolean {
    val configuration = LocalConfiguration.current
    return configuration.screenWidthDp > SMALL_TABLET_WIDTH
 }

+@SuppressLint("ConfigurationScreenWidthHeight")
 @Composable
 internal fun isTablet(): Boolean {
    val configuration = LocalConfiguration.current
    return configuration.screenWidthDp > TABLET_WIDTH
 }

+@SuppressLint("ConfigurationScreenWidthHeight")


[nitpick] Instead of repeating @SuppressLint on each function, consider applying @file:SuppressLint("ConfigurationScreenWidthHeight") at the top of the file to reduce duplication and improve maintainability.

Suggested change

@SuppressLint("ConfigurationScreenWidthHeight")

@Composable

internal fun isSmallTablet(): Boolean {

val configuration = LocalConfiguration.current

return configuration.screenWidthDp > SMALL_TABLET_WIDTH

}

@SuppressLint("ConfigurationScreenWidthHeight")

@Composable

internal fun isTablet(): Boolean {

val configuration = LocalConfiguration.current

return configuration.screenWidthDp > TABLET_WIDTH

}

@SuppressLint("ConfigurationScreenWidthHeight")

@file:SuppressLint("ConfigurationScreenWidthHeight")

@Composable

internal fun isSmallTablet(): Boolean {

val configuration = LocalConfiguration.current

return configuration.screenWidthDp > SMALL_TABLET_WIDTH

}

@Composable

internal fun isTablet(): Boolean {

val configuration = LocalConfiguration.current

return configuration.screenWidthDp > TABLET_WIDTH

}

nice one bot, instead of pointing out the risks of using SupressLint, you give an optimal way to supress the whole file, bravo 👏

Copilot · 2025-05-20T08:15:46Z

.../main/kotlin/net/skyscanner/backpack/compose/floatingnotification/BpkFloatingNotification.kt

@@ -48,6 +49,7 @@ import net.skyscanner.backpack.compose.floatingnotification.internal.floatingNot
 import net.skyscanner.backpack.compose.icon.BpkIcon
 import net.skyscanner.backpack.compose.tokens.BpkSpacing

+@SuppressLint("ConfigurationScreenWidthHeight")


[nitpick] You can apply @file:SuppressLint("ConfigurationScreenWidthHeight") for the entire file instead of per-function suppression to keep the file cleaner and avoid repetitive annotations.

Suggested change

@SuppressLint("ConfigurationScreenWidthHeight")

skyscanner-backpack-bot · 2025-05-20T11:06:28Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 4ed76fd

LokmaneKrizou · 2025-05-20T11:12:10Z

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/utils/DeviceUtil.kt

-import androidx.compose.ui.platform.LocalConfiguration
+import androidx.compose.ui.platform.LocalDensity
+import androidx.compose.ui.platform.LocalWindowInfo
+import androidx.compose.ui.unit.dp



nice work!
before merging this PR, can you run this change locally in skyscanner app to ensure we don't introduce breaking changes to the font, that would be great

You meant ./gradlew :app:recordScreenshots? I have run it and it looks fine to me

i mean publish to maven local and try the version on skyscanner app :D

Bumps androidx.compose:compose-bom from 2025.04.00 to 2025.04.01. --- updated-dependencies: - dependency-name: androidx.compose:compose-bom dependency-version: 2025.04.01 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

skyscanner-backpack-bot · 2025-05-20T13:05:46Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 39fccf2

skyscanner-backpack-bot · 2025-05-21T10:48:43Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against a2a7543

skyscanner-backpack-bot · 2025-05-21T14:12:44Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 592c84d

dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 24, 2025

EmmanuelBuraimo approved these changes May 19, 2025

View reviewed changes

peterInTown changed the title ~~Bump androidx.compose:compose-bom from 2025.04.00 to 2025.04.01~~ Bump androidx.compose:compose-bom from 2025.04.00 to 2025.05.00 May 19, 2025

LokmaneKrizou reviewed May 20, 2025

View reviewed changes

LokmaneKrizou requested a review from Copilot May 20, 2025 08:14

Copilot AI reviewed May 20, 2025

View reviewed changes

LokmaneKrizou reviewed May 20, 2025

View reviewed changes

dependabot bot and others added 7 commits May 20, 2025 14:04

Updated snapshots

afcdebd

[DON-NoTicket] bump compose bom version

6a1da98

[DON-NoTicket] add suppress lint

3bec4ec

[DON-NoTicket] replace local configuration

c07cead

[DON-NoTicket] update compose version to 2025.5.0

4f39db2

[DON-NoTicket] replace configuration with localwindowinfo

39fccf2

LokmaneKrizou force-pushed the dependabot/gradle/androidx.compose-compose-bom-2025.04.01 branch from 4ed76fd to 39fccf2 Compare May 20, 2025 13:04

[DON-NoTicket] fix edge to edge issue

a2a7543

henrik-sky approved these changes May 21, 2025

View reviewed changes

[DON-NoTicket] leave comment for deprecated code

592c84d

peterInTown merged commit 34beb84 into main May 21, 2025
7 checks passed

peterInTown deleted the dependabot/gradle/androidx.compose-compose-bom-2025.04.01 branch May 21, 2025 15:33

LokmaneKrizou mentioned this pull request May 28, 2025

INL-3110 revert back compose bom version #2310

Merged

3 tasks

Bump androidx.compose:compose-bom from 2025.04.00 to 2025.05.00 #2273

Bump androidx.compose:compose-bom from 2025.04.00 to 2025.05.00 #2273

Uh oh!

Conversation

dependabot bot commented on behalf of github Apr 24, 2025

Uh oh!

dependabot bot commented on behalf of github May 8, 2025

Uh oh!

LokmaneKrizou commented May 12, 2025

Uh oh!

skyscanner-backpack-bot bot commented May 19, 2025

Uh oh!

skyscanner-backpack-bot bot commented May 19, 2025

Uh oh!

skyscanner-backpack-bot bot commented May 19, 2025

Uh oh!

skyscanner-backpack-bot bot commented May 19, 2025

Uh oh!

LokmaneKrizou May 20, 2025

Choose a reason for hiding this comment

Uh oh!

peterInTown May 20, 2025

Choose a reason for hiding this comment

Uh oh!

LokmaneKrizou May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

LokmaneKrizou May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

skyscanner-backpack-bot bot commented May 20, 2025

Uh oh!

LokmaneKrizou May 20, 2025

Choose a reason for hiding this comment

Uh oh!

peterInTown May 20, 2025

Choose a reason for hiding this comment

Uh oh!

LokmaneKrizou May 20, 2025

Choose a reason for hiding this comment

Uh oh!

skyscanner-backpack-bot bot commented May 20, 2025

Uh oh!

skyscanner-backpack-bot bot commented May 21, 2025

Uh oh!

skyscanner-backpack-bot bot commented May 21, 2025

Uh oh!

Uh oh!

Uh oh!

LokmaneKrizou May 20, 2025 •

edited

Loading