Skip to content

Upgraded System.Net.Http and System.Text.RegularExpressions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

cyberzed
Copy link
Contributor

No description provided.

@cyberzed cyberzed requested a review from Copilot May 15, 2025 12:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the System.Net.Http and System.Text.RegularExpressions packages in the test project by adding direct references and updating the lock file to reflect new versions and dependencies.

  • Added direct PackageReferences for System.Net.Http (4.3.4) and System.Text.RegularExpressions (4.3.1) in the test .csproj.
  • Updated packages.lock.json with new direct entries and bumped transitive dependency versions for those packages.
  • Removed outdated transitive entries for System.Net.Http and System.Text.RegularExpressions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Sleddog.Blink1.Tests/packages.lock.json Added direct lock entries for Http and Regex, and bumped transitive dependency versions
src/Sleddog.Blink1.Tests/Sleddog.Blink1.Tests.csproj Added <PackageReference> entries for System.Net.Http and System.Text.RegularExpressions
Comments suppressed due to low confidence (2)

src/Sleddog.Blink1.Tests/Sleddog.Blink1.Tests.csproj:12

  • [nitpick] If the test code does not explicitly use Http APIs, consider removing this direct reference to keep dependencies minimal.
<PackageReference Include="System.Net.Http" Version="4.3.4" />

src/Sleddog.Blink1.Tests/Sleddog.Blink1.Tests.csproj:13

  • [nitpick] If tests don’t use advanced Regex features, you may not need a direct reference here; relying on transitive dependencies could simplify the project.
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />

@cyberzed cyberzed marked this pull request as ready for review May 15, 2025 12:04
@cyberzed cyberzed merged commit 4a4da22 into master May 15, 2025
3 checks passed
@cyberzed cyberzed deleted the fix-security-issues branch May 20, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant