Skip to content

ENH: Add all released Python version above 3.8 until 3.11 to CI#153

Merged
ljod merged 2 commits intoSlicerDMRI:masterfrom
jhlegarreta:AddFurtherPythonVersionsToCI
Oct 12, 2023
Merged

ENH: Add all released Python version above 3.8 until 3.11 to CI#153
ljod merged 2 commits intoSlicerDMRI:masterfrom
jhlegarreta:AddFurtherPythonVersionsToCI

Conversation

@jhlegarreta
Copy link
Copy Markdown
Contributor

@jhlegarreta jhlegarreta commented Sep 15, 2023 •
edited
Loading

  • ENH: Relax numpy install requirement version
  • ENH: Add all released Python version above 3.8 until 3.11 to CI

@jhlegarreta
Copy link
Copy Markdown
Contributor Author

jhlegarreta commented Sep 15, 2023 •
edited
Loading

All CI builds failing due to required package versions are not compatible with newer Python versions, e.g.:

distutils.errors.DistutilsError:
Command '['/opt/hostedtoolcache/Python/3.10.13/x64/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmp7wsmqwii', '--quiet', 'numpy==1.20.*']'
returned non-zero exit status 1.

for Python 3.10: https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6202578478/job/16841588997?pr=153#step:5:1425

Versions need to be relaxed (e.g. >=). Ideally, PR #146 should be merged before this, and it may well be the case that transitioning towards PEP 518 will necessary for Python 3.12.

This was referenced Sep 27, 2023
Merged
Merged
@jhlegarreta jhlegarreta force-pushed the AddFurtherPythonVersionsToCI branch from 34fa97b to e009047 Compare October 5, 2023 00:32
@jhlegarreta
Copy link
Copy Markdown
Contributor Author

jhlegarreta commented Oct 5, 2023

Removed Python 3.12 in e009047 as Python 3.12 requires using pyproject.toml. This will be addressed in a future PR.

@jhlegarreta jhlegarreta force-pushed the AddFurtherPythonVersionsToCI branch 5 times, most recently from 20fd253 to effc963 Compare October 6, 2023 18:28
@jhlegarreta
ENH: Relax numpy install requirement version
8224583 
Relax `numpy` install requirement version: require any version above a
minimum version. Any version installed through the requirements file
should be enough for the package to work as expected.
@jhlegarreta jhlegarreta force-pushed the AddFurtherPythonVersionsToCI branch 5 times, most recently from 370734e to 77d4b68 Compare October 6, 2023 19:52
@jhlegarreta
ENH: Add all released Python version above 3.8 until 3.11 to CI
772f14a 
Add all released Python version above 3.8 until 3.11 to CI: WMA is known
to work with Python 3.10, so add this and other versions so that there
can be an indication that the tool can be used with such versions.

Adapt the requirements file to install the appropriate versions for each
Python version.
@jhlegarreta jhlegarreta force-pushed the AddFurtherPythonVersionsToCI branch from 77d4b68 to 772f14a Compare October 6, 2023 20:22
@jhlegarreta
Copy link
Copy Markdown
Contributor Author

jhlegarreta commented Oct 6, 2023

All versions are now working: the package is installed properly across all Python versions tested.

Tests are failing across all Python versions due to the same reasons reported in #154 (comment). But tests are picked, e.g.
https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6436137665/job/17478869066?pr=153#step:5:546
https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6436137665/job/17478868858?pr=153#step:5:757

So this is ready to be merged.

@jhlegarreta jhlegarreta changed the title ENH: Add all released Python version above 3.8 to CI ENH: Add all released Python version above 3.8 until 3.11 to CI Oct 6, 2023
@ljod ljod merged commit 7ac748c into SlicerDMRI:master Oct 12, 2023
@jhlegarreta jhlegarreta deleted the AddFurtherPythonVersionsToCI branch October 12, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljod ljod ljod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhlegarreta @ljod