STYLE: Prefer using lowercase to name package#162
Merged
ljod merged 1 commit intoSlicerDMRI:masterfrom Oct 5, 2023
Merged
Conversation
Prefer using lowercase to name package in line with other relevant scientific computing Python packages. Change it as well in the commented PyPI URL (note that the package was never been uploaded to PyPI, and thus, changing the package name at this stage is safe from that point of view).
Contributor
Author
|
Cross-referencing #154 (comment). I assume this has no impact on the package being available as a 3D Slicer module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer using lowercase to name package in line with other relevant scientific computing Python packages.
Change it as well in the commented PyPI URL (note that the package was never been uploaded to PyPI, and thus, changing the package name at this stage is safe from that point of view).