Skip to content

STYLE: Refactor argparsing to own methods in scripts#174

Merged
ljod merged 2 commits intoSlicerDMRI:masterfrom
jhlegarreta:RefactorArgParsingToOwnMethods
Oct 12, 2023
Merged

STYLE: Refactor argparsing to own methods in scripts#174
ljod merged 2 commits intoSlicerDMRI:masterfrom
jhlegarreta:RefactorArgParsingToOwnMethods

Conversation

@jhlegarreta
Copy link
Copy Markdown
Contributor

  • STYLE: Refactor argparsing to own methods in scripts
  • DOC: Remove unnecessary/uninformative documentation block

@jhlegarreta
Copy link
Copy Markdown
Contributor Author

To be rebased on master after PR #167 gets merged.

Refactor argparsing to own methods in scripts.

Take advantage of the commit to remove unnecessary comment about the
block parsing input arguments.
Remove unnecessary/uninformative documentation block about the
argparsing and the script logic section division.
@jhlegarreta jhlegarreta force-pushed the RefactorArgParsingToOwnMethods branch from b4bce00 to 617a578 Compare October 12, 2023 14:18
@jhlegarreta jhlegarreta marked this pull request as ready for review October 12, 2023 14:18
@jhlegarreta
Copy link
Copy Markdown
Contributor Author

Errors are unrelated: pytest is still picking testing/test_run.py which does not work since the testing data is missing.

Ready to be merged.

@ljod ljod merged commit 42d9c86 into SlicerDMRI:master Oct 12, 2023
@jhlegarreta jhlegarreta deleted the RefactorArgParsingToOwnMethods branch October 12, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants