ENH: Relocate contents in test_run.py to tests#176
Merged
ljod merged 2 commits intoSlicerDMRI:masterfrom Oct 19, 2023
Merged
Conversation
Add missing test for `wm_cluster_remove_outliers.py` script. Left behind in commit cf5ddd8.
Relocate contents in `test_run.py` to the appropriate tests:
- The file is removed, and thus removed from the scripts list in
`setup.py`.
- The relocated contents are commented out as no testing data exists
yet.
Allows tests to pass. Fixes:
```
==================================== ERRORS ====================================
_____________________ ERROR collecting testing/test_run.py _____________________
(...)
testing/test_run.py:17: in <module>
wm_quality_control_tractography.main()
bin/wm_quality_control_tractography.py:56: in main
exit()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/_sitebuiltins.py:26: in __call__
raise SystemExit(code)
E SystemExit: None
------------------------------- Captured stdout --------------------------------
Importing whitematteranalysis package.
<wm_quality_control_tractography.py> Starting...
<wm_quality_control_tractography.py> Error: Input directory input_tractography/ does not exist.
```
raised for example in:
https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6499690724/job/17653542925?pr=157#step:6:849
Contributor
Author
|
PR #173 should be merged before this one. Tests will still fail because there is an error unrelated to the tests and having to do with the version of raised for exampled in This is addressed in |
Contributor
Author
|
Further test cases can be imported from PR #74 in a separate PR. |
ljod
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wm_cluster_remove_outliers.pyscripttest_run.pyto tests