Update requirements.txt to accept more python/vtk versions#244
Conversation
Possible fix for the issue reported here: https://discourse.slicer.org/t/slicer-doesnt-open-after-installing-slicerwma-extension/42356
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Have not tested locally. I am fine with these as long as the CIs are passing. Thanks Steve.
Python 3.8 is end-of-life and no longer supported. https://devguide.python.org/versions/
|
@jhlegarreta please review and approve so we can test this in tomorrow's build. |
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Dropping a Python version means a major version update:
https://github.com/SlicerDMRI/whitematteranalysis/blob/master/setup.py#L35
So, it would mean a 1.0.0 version.
Also, I see that there is no python_requires section in the setup.py file. Maybe it is a good time to do that.
Can these changes be made?
|
@jhlegarreta the authors of this extension have no time to help with this right now and @ljod would like to have a working version for the Slicer extension to correct a serious regression. If you have time to implement your suggestions please do, otherwise let's merge this. |
3 participants
Possible fix for the issue reported here:
https://discourse.slicer.org/t/slicer-doesnt-open-after-installing-slicerwma-extension/42356