Performance Improvements#215
Open
md5sha256 wants to merge 4 commits intoSlimefun-Addon-Community:masterfrom
Open
Performance Improvements#215md5sha256 wants to merge 4 commits intoSlimefun-Addon-Community:masterfrom
md5sha256 wants to merge 4 commits intoSlimefun-Addon-Community:masterfrom
Conversation
Contributor
|
Stated comments in Discord but otherwise looks alright. |
019c678 to
2270757
Compare
Author
|
So basic benchmark: 3786 (omit because JIT?), 3233 (omit . . .), 1168, 1028, 1021 (10k schem pastes, with physics) 793, 766, 789, 1305, 807 (10k schem pastes without physics) all units in ms. So roughly a 30% performance improvement code used to test: here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested/benchmarked the changes of this PR on a live server just yet.
This PR adds non-breaking performance improvements in various places.
Math.floorDivand not needing to create a newLocationobject for each block being pasted.List<Material>which only havecontainscalls have been replaced withEnumSet