Fixed interaction with Brewery cauldrons#217
Open
TristanVdElzen wants to merge 1 commit intoSlimefun-Addon-Community:masterfrom
Open
Fixed interaction with Brewery cauldrons#217TristanVdElzen wants to merge 1 commit intoSlimefun-Addon-Community:masterfrom
TristanVdElzen wants to merge 1 commit intoSlimefun-Addon-Community:masterfrom
Conversation
Cauldrons for making brews in the Brewery plugin can now take ExoticGarden fruits again. Regular cauldrons will not be interactable, preventing fruit placement and bush duplication exploit. When brewery is not installed `isBreweryCauldron()` returns false causing it not to be interactable, as expected.
|
I think it will be simply solved by only removing cauldon from |
Author
No. When it is a regular cauldron isInteractable() should return false as otherwise you would place the fruits on the cauldron, but when it is a cauldron from the Brewery plugin it should return true as otherwise the fruit will be eaten instead of inserted. This is why I've created a separate method for exactly this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cauldrons for making brews in the Brewery plugin can now take ExoticGarden fruits again. Regular cauldrons will not be interactable, preventing fruit placement and bush duplication exploit. When brewery is not installed
isBreweryCauldron()returns false causing it not to be interactable, as expected.Fixes: