支持 Folia #1059

StarWishsama · 2025-05-05T13:56:48Z

*: BlockTicker#isConcurrentSafe() 用于标记当前机器 Ticker 是并发安全的，Slimefun 默认认为附属的机器是并发不安全的，并移至异步单线程处理这些机器。

# Conflicts: # src/main/java/city/norain/slimefun4/utils/TaskUtil.java # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java

# Conflicts: # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java

Folia remove support for player respawn related event

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java

… machine refactor(ticker): adjust thread pool argument for better load balanced performance

# Conflicts: # src/main/java/me/mrCookieSlime/CSCoreLibPlugin/general/Inventory/ChestMenu.java

ClayCoffee · 2025-12-16T19:13:29Z

是鸽了吗

StarWishsama · 2025-12-17T00:02:31Z

是鸽了吗

没有，只是需要自己编译，反馈的相关问题也会处理的

# Conflicts: # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/util/StorageCacheUtils.java # src/main/java/io/github/thebusybiscuit/slimefun4/api/gps/GPSNetwork.java # src/main/java/io/github/thebusybiscuit/slimefun4/api/gps/TeleportationManager.java # src/main/java/io/github/thebusybiscuit/slimefun4/core/services/holograms/HologramsService.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/geo/GEOMiner.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/AsyncRecipeChoiceTask.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

Copilot

Pull request overview

This pull request adds Folia support to Slimefun, a major architectural change that migrates the plugin from Bukkit's traditional scheduler to a region-based scheduler using the FoliaLib library. The PR addresses multi-threading concerns and fixes issue #1082 related to multi-block structures not working properly on Folia.

Key changes:

Migrates all scheduler calls from BukkitScheduler to FoliaLib's PlatformScheduler with location/entity context
Introduces concurrent execution support for BlockTickers with a thread pool architecture
Replaces thread-unsafe data structures with concurrent alternatives (ConcurrentHashMap, CopyOnWriteArraySet, etc.)
Implements a custom TaskQueue for Folia-compatible sequential task execution

Reviewed changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
plugin.yml	Adds `folia-supported: true` flag to declare Folia compatibility
config.yml	Introduces thread pool configuration for async ticker system
Slimefun.java	Integrates FoliaLib and adds location/entity-aware scheduling methods
TickerTask.java	Implements concurrent ticker execution with thread pool and fallback mechanism
TaskQueue.java	New Folia-compatible task queue with location/entity context support
BlockTicker.java	Adds concurrent safety API (`isConcurrent()`, `useUniversalData()`)
Multiple task files	Updates all scheduler calls to use PlatformScheduler with proper context
Multiple data structures	Replaces HashMap/HashSet with ConcurrentHashMap/CopyOnWriteArraySet
ChestMenu.java	Replaces AtomicBoolean lock with ReentrantLock for proper mutex behavior
pom.xml	Adds FoliaLib dependency and relocation configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-25T12:34:25Z

src/main/java/city/norain/slimefun4/utils/TaskUtil.java

+                if (Slimefun.isFolia()) {
+                    final CompletableFuture<T> result = new CompletableFuture<>();
+
+                    System.out.println("Sync task created, hashcode = " + result.hashCode());


Debug print statement should be removed before merging to production. This will spam the console with synchronization task information.

Copilot · 2025-12-25T12:34:26Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+            change = true;
+        }
+
+        var poolSize = Slimefun.getCfg().getInt("URID.custom-async-ticker.pool-size");


The configuration key used here ('URID.custom-async-ticker.pool-size') does not match the key defined in config.yml ('URID.custom-async-ticker.queue-size'). This inconsistency will cause the configuration value to be read incorrectly, potentially using a default value of 0 and triggering the validation warning.

Copilot · 2025-12-25T12:34:26Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+            Slimefun.logger().log(Level.WARNING, "当前设置的 Ticker 线程池初始大小过大，已被重设至 {0}，建议修改为小于 {1} 的值。", new Object[] {
+                maxSize, maxSize - 1
+            });
+            Slimefun.getCfg().setValue("URID.custom.async-ticker.init-size", initSize);


The configuration key used for saving ('URID.custom.async-ticker.init-size') has a dot between 'custom' and 'async-ticker', which doesn't match the key used for reading ('URID.custom-async-ticker.init-size' without the dot). This will cause the corrected value to be saved to a different location than where it's read from.

Copilot · 2025-12-25T12:34:26Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/config/SlimefunConfigManager.java

+                    "URID.custom.async-ticker.init-size", Runtime.getRuntime().availableProcessors() / 2);
+            pluginConfig.setDefaultValue(
+                    "URID.custom.async-ticker.max-size", Runtime.getRuntime().availableProcessors());
+            pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);
+
+            asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");
+            asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");
+            asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");


The configuration key 'URID.custom.async-ticker.init-size' contains an extra dot between 'custom' and 'async-ticker'. This should be 'URID.custom-async-ticker.init-size' to match the key used in config.yml and when reading the configuration value.

Suggested change

"URID.custom.async-ticker.init-size", Runtime.getRuntime().availableProcessors() / 2);

pluginConfig.setDefaultValue(

"URID.custom.async-ticker.max-size", Runtime.getRuntime().availableProcessors());

pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");

"URID.custom-async-ticker.init-size", Runtime.getRuntime().availableProcessors() / 2);

pluginConfig.setDefaultValue(

"URID.custom-async-ticker.max-size", Runtime.getRuntime().availableProcessors());

pluginConfig.setDefaultValue("URID.custom-async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom-async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom-async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom-async-ticker.queue-size");

Copilot · 2025-12-25T12:34:26Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/config/SlimefunConfigManager.java

+                    "URID.custom.async-ticker.init-size", Runtime.getRuntime().availableProcessors() / 2);
+            pluginConfig.setDefaultValue(
+                    "URID.custom.async-ticker.max-size", Runtime.getRuntime().availableProcessors());
+            pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);
+
+            asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");
+            asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");
+            asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");


The configuration key 'URID.custom.async-ticker.init-size' contains an extra dot between 'custom' and 'async-ticker'. This should be 'URID.custom-async-ticker.init-size' to match the key defined as the default and used elsewhere in the codebase.

Suggested change

"URID.custom.async-ticker.init-size", Runtime.getRuntime().availableProcessors() / 2);

pluginConfig.setDefaultValue(

"URID.custom.async-ticker.max-size", Runtime.getRuntime().availableProcessors());

pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");

"URID.custom-async-ticker.init-size", Runtime.getRuntime().availableProcessors() / 2);

pluginConfig.setDefaultValue(

"URID.custom-async-ticker.max-size", Runtime.getRuntime().availableProcessors());

pluginConfig.setDefaultValue("URID.custom-async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom-async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom-async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom-async-ticker.queue-size");

Copilot · 2025-12-25T12:34:27Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+        if (poolSize < 0) {
+            Slimefun.logger().log(Level.WARNING, "当前设置的 Ticker 线程池任务队列大小异常，已自动设置为 1024，请修改为一个正常的大小");
+            poolSize = 512;
+            Slimefun.getCfg().setValue("URID.custom-async-ticker.pool-size", poolSize);


The configuration key 'URID.custom-async-ticker.pool-size' used for saving doesn't match the key 'URID.custom-async-ticker.queue-size' defined in config.yml and used in SlimefunConfigManager. This inconsistency will save the value to the wrong location.

Copilot · 2025-12-25T12:34:27Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/config/SlimefunConfigManager.java

+                    "URID.custom.async-ticker.max-size", Runtime.getRuntime().availableProcessors());
+            pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);
+
+            asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");
+            asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");


The configuration key 'URID.custom.async-ticker.max-size' contains an extra dot between 'custom' and 'async-ticker'. This should be 'URID.custom-async-ticker.max-size' to match the key used in config.yml and when reading the configuration value in TickerTask.

Suggested change

"URID.custom.async-ticker.max-size", Runtime.getRuntime().availableProcessors());

pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

"URID.custom-async-ticker.max-size", Runtime.getRuntime().availableProcessors());

pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom-async-ticker.max-size");

Copilot · 2025-12-25T12:34:28Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/config/SlimefunConfigManager.java

+            pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);
+
+            asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");
+            asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");
+            asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");


The configuration key 'URID.custom.async-ticker.queue-size' contains an extra dot between 'custom' and 'async-ticker'. This should be 'URID.custom-async-ticker.queue-size' to match the key used in config.yml.

Suggested change

pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");

pluginConfig.setDefaultValue("URID.custom-async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom-async-ticker.queue-size");

Copilot · 2025-12-25T12:34:28Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/config/SlimefunConfigManager.java

+            pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);
+
+            asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");
+            asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");
+            asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");


The configuration key 'URID.custom.async-ticker.queue-size' contains an extra dot between 'custom' and 'async-ticker'. This should be 'URID.custom-async-ticker.queue-size' to match the key defined as the default and used elsewhere in the codebase.

Suggested change

pluginConfig.setDefaultValue("URID.custom.async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom.async-ticker.queue-size");

pluginConfig.setDefaultValue("URID.custom-async-ticker.queue-size", 1024);

asyncTickerInitSize = pluginConfig.getInt("URID.custom.async-ticker.init-size");

asyncTickerMaxSize = pluginConfig.getInt("URID.custom.async-ticker.max-size");

asyncTickerQueueSize = pluginConfig.getInt("URID.custom-async-ticker.queue-size");

Copilot · 2025-12-25T12:34:28Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+        var poolSize = Slimefun.getCfg().getInt("URID.custom-async-ticker.pool-size");
+
+        if (poolSize < 0) {
+            Slimefun.logger().log(Level.WARNING, "当前设置的 Ticker 线程池任务队列大小异常，已自动设置为 1024，请修改为一个正常的大小");


The error message mentions 'queue-size' but should say 'pool-size' based on the variable name and context. However, note that there's also a configuration key mismatch issue where 'pool-size' is used in code but 'queue-size' is defined in config.yml.

Copilot

Pull request overview

Copilot reviewed 61 out of 61 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-26T06:26:57Z

src/main/java/city/norain/slimefun4/utils/TaskUtil.java

+                if (Slimefun.isFolia()) {
+                    final CompletableFuture<T> result = new CompletableFuture<>();
+
+                    System.out.println("Sync task created, hashcode = " + result.hashCode());


The debug print statement should be removed before merging to production. Debug statements left in production code can clutter logs and potentially expose sensitive information.

Copilot · 2025-12-26T06:26:57Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/config/SlimefunConfigManager.java

+        }
+
+        if (asyncTickerQueueSize < 0) {
+            asyncTickerInitSize = 1024;


The variable name 'asyncTickerInitSize' is being incorrectly assigned when 'asyncTickerQueueSize' validation fails. This should set 'asyncTickerQueueSize' to 1024, not 'asyncTickerInitSize'. This is a copy-paste error that will cause incorrect configuration behavior.

Suggested change

asyncTickerInitSize = 1024;

asyncTickerQueueSize = 1024;

Copilot · 2025-12-26T06:26:57Z

src/main/java/me/mrCookieSlime/CSCoreLibPlugin/general/Inventory/ChestMenu.java

    public boolean locked() {
-        return lock.get();
+        return lock.isLocked();
    }


The ChestMenu lock mechanism has been changed from AtomicBoolean to ReentrantLock, but the 'locked()' method only checks if the lock is currently held by any thread. This doesn't match the previous semantics where the lock was a boolean flag. If no thread holds the lock, 'isLocked()' returns false even if lock() was called. Consider using a boolean field alongside the ReentrantLock if you need to track lock state independently of actual acquisition, or ensure callers understand that 'locked()' only indicates current lock ownership.

Copilot · 2025-12-26T06:26:58Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+    public void shutdown() {
+        setPaused(true);
+        halt();
+
+        try {
+            asyncTickerService.shutdown();
+            if (!asyncTickerService.awaitTermination(10, TimeUnit.SECONDS)) {
+                asyncTickerService.shutdownNow();
+            }
+        } catch (InterruptedException e) {
+            asyncTickerService.shutdownNow();
+        } finally {
+            asyncTickerService = null;
+        }
+
+        try {
+            fallbackTickerService.shutdown();
+            if (!fallbackTickerService.awaitTermination(10, TimeUnit.SECONDS)) {
+                fallbackTickerService.shutdownNow();
+            }
+        } catch (InterruptedException e) {
+            fallbackTickerService.shutdownNow();
+        } finally {
+            fallbackTickerService = null;
+        }
+    }


The shutdown logic in TickerTask may cause issues during server shutdown. After calling 'setPaused(true)' and 'halt()', the running flag is set but tasks might still be executing in the thread pools. The 10-second timeout for awaitTermination may not be sufficient for all tasks to complete, especially if they're waiting on I/O or other operations. Consider adding proper task cancellation mechanisms or increasing the timeout. Also, setting the executor service references to null in finally blocks could cause NullPointerExceptions if shutdown is called multiple times.

Copilot · 2025-12-26T06:26:58Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+        this.asyncTickerService = new SlimefunPoolExecutor(
+                "Slimefun-Ticker-Pool",
+                initSize - 1,
+                maxSize - 1,
+                1,
+                TimeUnit.MINUTES,
+                new LinkedBlockingQueue<>(poolSize),
+                tickerThreadFactory,
+                (r, e) -> {
+                    // 任务队列已满，使用备用的单线程池执行该任务
+                    fallbackTickerService.submit(r);
+                });


In the TickerTask initialization, when creating the asyncTickerService, the code uses 'initSize - 1' and 'maxSize - 1' for the thread pool sizes. This means if a user configures initSize=2 and maxSize=8, they'll actually get a pool with corePoolSize=1 and maximumPoolSize=7. This doesn't match the configuration documentation which states these values represent the actual thread counts. Either remove the '- 1' or update the documentation to clarify this behavior.

Copilot · 2025-12-26T06:26:59Z

src/main/java/me/mrCookieSlime/Slimefun/Objects/handlers/BlockTicker.java

+
+    /**
+     * 声明当前 {@link BlockTicker} 是否线程安全
+     * </br>


The javadoc comment contains HTML tags (</br>) which should be proper JavaDoc tags. The line break should be written as '<br>' (without the closing tag) in JavaDoc, or use '<p>' tags for paragraph separation. The current syntax may not render correctly in generated documentation.

Copilot · 2025-12-26T06:26:59Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

+                    Runnable func = () -> {
+                        try {
+                            if (Slimefun.isFolia()) {
+                                Slimefun.getPlatformScheduler()
+                                        .runAtLocation(l, task -> tickBlock(l, item, data, timestamp));
+                            } else {
+                                tickBlock(l, item, data, timestamp);
+                            }
+                        } catch (Exception x) {
+                            reportErrors(l, item, x);
+                        }
+                    };
+
+                    if (item.getBlockTicker().isConcurrent()) {
+                        asyncTickerService.execute(func);
+                    } else {
+                        fallbackTickerService.execute(func);
+                    }


There's a nested Folia check that might cause double-scheduling. When 'isConcurrent()' is true, the task is submitted to 'asyncTickerService', which executes the 'func' runnable. Inside 'func', there's another check for 'Slimefun.isFolia()' at line 272 that schedules another task with 'runAtLocation'. This means on Folia, the task will be scheduled twice - once by the executor service and once by runAtLocation. This could cause the same tick to execute multiple times or in the wrong order. Consider restructuring the logic to avoid double-scheduling.

Copilot · 2025-12-26T06:27:00Z

src/main/java/city/norain/slimefun4/dough/TaskQueue.java

+    private void scheduleGeneral(@Nonnull TaskNode node, @Nonnull Runnable runnable) {
+        if (node.isAsynchronous()) {
+            if (node.getDelay() > 0) {
+                Slimefun.getPlatformScheduler().runLater(runnable, node.getDelay());
+            } else {
+                Slimefun.getPlatformScheduler().runNextTick((task) -> runnable.run());
+            }
+        } else {
+            if (node.getDelay() > 0) {
+                Slimefun.getPlatformScheduler().runLaterAsync(runnable, node.getDelay());
+            } else {
+                Slimefun.getPlatformScheduler().runAsync((task) -> runnable.run());
+            }
+        }
+    }


The conditions in the scheduleGeneral method appear to be inverted. When 'isAsynchronous()' returns true, the code schedules the task asynchronously (lines 92-95), but when it returns false, it schedules synchronously (lines 84-89). This is backwards - an asynchronous task should be scheduled with async methods, and a synchronous task should be scheduled with sync methods.

Copilot · 2025-12-26T06:27:00Z

src/main/java/city/norain/slimefun4/utils/TaskUtil.java

+    public <T> T runSyncMethod(@Nonnull Callable<T> callable) {
+        if (Slimefun.isFolia()) {
+            throw new IllegalArgumentException("Location must be provided when executing sync task on Folia!");
+        }
+
+        return runSyncMethod(callable, null, null);
+    }
+
+    @SneakyThrows
+    public <T> T runSyncMethod(@Nonnull Callable<T> callable, @Nonnull Location l) {
+        return runSyncMethod(callable, l, null);
+    }
+
+    @SneakyThrows
+    public <T> T runSyncMethod(@Nonnull Callable<T> callable, @Nonnull Entity entity) {
+        if (Slimefun.isFolia()) {
+            throw new IllegalArgumentException("Entity must be provided when executing sync task on Folia!");
+        }
+
+        return runSyncMethod(callable, null, entity);
+    }
+
+    @SneakyThrows
+    public <T> T runSyncMethod(@Nonnull Callable<T> callable, @Nullable Location l, @Nullable Entity entity) {
        if (Bukkit.isPrimaryThread()) {
            return callable.call();
        } else {
            try {
-                return Bukkit.getScheduler()
-                        .callSyncMethod(Slimefun.instance(), callable)
-                        .get(1, TimeUnit.SECONDS);
+                if (Slimefun.isFolia()) {
+                    final CompletableFuture<T> result = new CompletableFuture<>();
+
+                    System.out.println("Sync task created, hashcode = " + result.hashCode());
+
+                    if (l != null) {
+                        Slimefun.getPlatformScheduler().runAtLocation(l, task -> {
+                            try {
+                                result.complete(callable.call());
+                            } catch (Exception e) {
+                                result.completeExceptionally(e);
+                            }
+                        });
+                    } else {
+                        if (entity != null) {
+                            Slimefun.getPlatformScheduler().runAtEntity(entity, task -> {
+                                try {
+                                    result.complete(callable.call());
+                                } catch (Exception e) {
+                                    result.completeExceptionally(e);
+                                }
+                            });
+                        } else {
+                            throw new IllegalArgumentException(
+                                    "Location or entity must be provided when executing sync task on Folia!");
+                        }


The exception handling logic in TaskUtil.runSyncMethod appears problematic. When Folia is enabled and the location/entity parameter is null, the code throws IllegalArgumentException with message about requiring location or entity. However, at line 31-32, the method already throws an exception if Folia is enabled without a location. This creates inconsistent error handling - the signature doesn't enforce non-null parameters for Folia, but the implementation requires them. Consider adding proper parameter validation annotations or creating separate method overloads for Folia vs non-Folia environments.

Copilot · 2025-12-26T06:27:00Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

-                synchronized (tickingLocations) {
-                    loc = new HashSet<>(tickingLocations.entrySet());
-                }
+                loc = new HashSet<>(tickingLocations.entrySet());


The removal of the synchronized block around 'new HashSet<>(tickingLocations.entrySet())' at line 154 could cause issues. While ConcurrentHashMap's entrySet() is thread-safe for iteration, creating a new HashSet from it during concurrent modifications might miss or duplicate entries if the map is being modified during the copy operation. The original synchronized block ensured a consistent snapshot. Consider whether this change could lead to missed or duplicate ticks.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

# Conflicts: # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/reactors/Reactor.java

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 61 out of 61 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T14:34:21Z

src/main/java/city/norain/slimefun4/dough/TaskQueue.java

+                Slimefun.getPlatformScheduler().runLater(runnable, node.getDelay());
+            } else {
+                Slimefun.getPlatformScheduler().runNextTick((task) -> runnable.run());
+            }
+        } else {
+            if (node.getDelay() > 0) {
+                Slimefun.getPlatformScheduler().runLaterAsync(runnable, node.getDelay());
+            } else {
+                Slimefun.getPlatformScheduler().runAsync((task) -> runnable.run());


The logic in scheduleGeneral appears to be inverted. When node.isAsynchronous() is true, the code schedules synchronously (runLater/runNextTick), and when it's false, it schedules asynchronously (runLaterAsync/runAsync). This should be corrected so that asynchronous nodes run asynchronously and synchronous nodes run synchronously.

Suggested change

Slimefun.getPlatformScheduler().runLater(runnable, node.getDelay());

} else {

Slimefun.getPlatformScheduler().runNextTick((task) -> runnable.run());

}

} else {

if (node.getDelay() > 0) {

Slimefun.getPlatformScheduler().runLaterAsync(runnable, node.getDelay());

} else {

Slimefun.getPlatformScheduler().runAsync((task) -> runnable.run());

Slimefun.getPlatformScheduler().runLaterAsync(runnable, node.getDelay());

} else {

Slimefun.getPlatformScheduler().runAsync((task) -> runnable.run());

}

} else {

if (node.getDelay() > 0) {

Slimefun.getPlatformScheduler().runLater(runnable, node.getDelay());

} else {

Slimefun.getPlatformScheduler().runNextTick((task) -> runnable.run());

Copilot · 2026-01-21T14:34:21Z

src/main/resources/config.yml

+  # 自定义 Ticker 的异步线程池配置
+  custom-async-ticker:
+    # 线程池初始线程数, 推荐数为主机的 CPU 核心数
+    init-size: 2
+    # 线程数最大线程数，推荐数为主机的 CPU 核心数 * 2
+    max-size: 8
+    # 每个线程池的任务队列大小，数值越大每个线程能处理的任务越多，但会增加总体延迟
+    queue-size: 1024


The Chinese comments mention "线程池初始线程数" (initial thread count) and "线程数最大线程数" (maximum thread count), but the actual parameter names in the code use "init-size" and "max-size" which are ambiguous. In thread pool terminology, these typically refer to core pool size and maximum pool size. Consider renaming these configuration keys to be more explicit, such as "core-pool-size" and "max-pool-size" to match standard Java ExecutorService terminology and avoid confusion.

Copilot · 2026-01-21T14:34:21Z

src/main/java/me/mrCookieSlime/CSCoreLibPlugin/general/Inventory/ChestMenu.java

    public boolean locked() {
-        return lock.get();
+        return lock.isLocked();
    }

    public void lock() {
-        lock.getAndSet(true);
+        lock.lock();
        InventoryUtil.closeInventory(this.inventory);
    }

    public void unlock() {
-        lock.getAndSet(false);
+        lock.unlock();
    }


The ReentrantLock is being used in ChestMenu to replace AtomicBoolean for locking, but the locked() method only checks isLocked() without checking if the current thread owns the lock. This could lead to incorrect behavior if multiple threads are involved, as isLocked() returns true if ANY thread holds the lock, not just the current thread. If the intention is to prevent re-entrant operations by the same thread, consider using tryLock() instead or checking lock ownership. Additionally, ensure that unlock() is always called in a finally block to prevent deadlocks if an exception occurs between lock() and unlock().

Copilot · 2026-01-21T14:34:22Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/cargo/TrashCan.java

+                try {
+                    menu.lock();
+
+                    for (int slot : getInputSlots()) {
+                        menu.replaceExistingItem(slot, null);
+                    }
+                } finally {
+                    menu.unlock();
                }


The TrashCan implementation correctly locks and unlocks the menu in a try-finally block, which is good practice. However, the lock is acquired on every tick, which means if the ticker is executing concurrently, multiple threads could contend for this lock frequently. While this is thread-safe, it might impact performance. Consider whether the lock granularity is appropriate, or if there's a more efficient way to handle concurrent access to the trash can's inventory slots.

Copilot · 2026-01-21T14:34:22Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/TickerTask.java

                l.getBlockX(), l.getBlockY(), l.getBlockZ(), item.getId()
            });
-            Slimefun.logger().log(Level.SEVERE, "在过去的 4 个 Tick 中发生多次错误，该方块对应的机器已被停用。");
+            Slimefun.logger().log(Level.SEVERE, "该位置上的机器在过去一段时间内多次报错，对应机器已被停用。");


The error message uses Chinese characters "该位置上的机器在过去一段时间内多次报错，对应机器已被停用。" The comment change appears to make the message less specific (changing from "在过去的 4 个 Tick 中发生多次错误" which mentions "4 Ticks" to "在过去一段时间内" which just says "a period of time"). However, this is marked as a change rather than a fix in context. Verify that this error message change is intentional and accurate, as the bug tracking logic may have changed.

Copilot · 2026-01-21T14:34:23Z

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java

        }

-        return instance.getServer().getScheduler().runTaskLater(instance, runnable, delay);
+        return getPlatformScheduler().runLater(runnable, Math.max(1, delay));


The delay parameter is being passed with Math.max(1, delay) in runSync, but the validation already ensures delay >= 0. If delay is 0, this forces it to 1 tick. This changes the behavior from immediate execution (delay 0) to delayed execution (delay 1), which might not be the intended behavior. If delay of 0 should execute immediately, consider using runNextTick() instead when delay is 0, otherwise document why minimum delay of 1 is enforced.

Copilot · 2026-01-21T14:34:23Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/services/github/GitHubTask.java

                                "Attempted to refresh skin cache, got this response: {0}: {1}",
                                new Object[] {x.getClass().getSimpleName(), x.getMessage()});
+                Slimefun.logger().log(Level.WARNING, "Error during refreshing skin cache", x);


A new log statement has been added to log the exception when skin cache refresh fails. However, the exception is logged twice: once with Level.WARNING and a custom message, and then again with the exception details. This creates duplicate log entries. Consider consolidating into a single log statement that includes both the message and the exception, for example: Slimefun.logger().log(Level.WARNING, "Attempted to refresh skin cache, got response: " + x.getClass().getSimpleName() + ": " + x.getMessage(), x);

Suggested change

"Attempted to refresh skin cache, got this response: {0}: {1}",

new Object[] {x.getClass().getSimpleName(), x.getMessage()});

Slimefun.logger().log(Level.WARNING, "Error during refreshing skin cache", x);

"Attempted to refresh skin cache, got response: "

+ x.getClass().getSimpleName()

+ ": "

+ x.getMessage(),

x);

Copilot · 2026-01-21T14:34:23Z

src/main/java/city/norain/slimefun4/utils/TaskUtil.java

+    public <T> T runSyncMethod(@Nonnull Callable<T> callable) {
+        return runSyncMethod(callable, null, null);
+    }
+
+    @SneakyThrows
+    public <T> T runSyncMethod(@Nonnull Callable<T> callable, @Nonnull Location l) {
+        return runSyncMethod(callable, l, null);
+    }
+
+    @SneakyThrows
+    public <T> T runSyncMethod(@Nonnull Callable<T> callable, @Nonnull Entity entity) {
+        return runSyncMethod(callable, null, entity);
+    }
+
+    @SneakyThrows
+    private <T> T runSyncMethod(@Nonnull Callable<T> callable, @Nullable Location l, @Nullable Entity entity) {
+        if (!Slimefun.isFolia()) {
+            return Bukkit.isPrimaryThread()
+                    ? callable.call()
+                    : Bukkit.getScheduler()
+                            .callSyncMethod(Slimefun.instance(), callable)
+                            .get(2, TimeUnit.SECONDS);
+        }
+
+        final CompletableFuture<T> result = new CompletableFuture<>();
+
+        if (l != null) {
+            Slimefun.getPlatformScheduler().runAtLocation(l, task -> {
+                try {
+                    result.complete(callable.call());
+                } catch (Exception e) {
+                    result.completeExceptionally(e);
+                }
+            });
        } else {
-            try {
-                return Bukkit.getScheduler()
-                        .callSyncMethod(Slimefun.instance(), callable)
-                        .get(1, TimeUnit.SECONDS);
-            } catch (TimeoutException e) {
-                Slimefun.logger().log(Level.WARNING, "Timeout when executing sync method", e);
-                return null;
+            if (entity != null) {
+                Slimefun.getPlatformScheduler().runAtEntity(entity, task -> {
+                    try {
+                        result.complete(callable.call());
+                    } catch (Exception e) {
+                        result.completeExceptionally(e);
+                    }
+                });
+            } else {
+                throw new IllegalArgumentException(
+                        "Location or entity must be provided when executing sync task on Folia!");
            }
        }
+
+        return result.get(2, TimeUnit.SECONDS);
    }


The runSyncMethod implementation for Folia requires either a Location or Entity to be provided, but when both are null, it throws an IllegalArgumentException. However, the no-argument version runSyncMethod(Callable) calls the private method with both parameters as null, which will always throw an exception on Folia. This breaks the API contract. Consider either using a global region scheduler for Folia when no location/entity is provided, or documenting that the no-argument version is not supported on Folia.

Copilot · 2026-01-21T14:34:24Z

src/main/java/me/mrCookieSlime/Slimefun/Objects/handlers/BlockTicker.java

+    /**
+     * 声明当前 {@link BlockTicker} 是否线程安全
+     * </br>
+     * 默认不启用，此时会将这些机器放置到单线程调度器 (旧方法) 上运行
+     *
+     * @return 是否并发安全
+     */
+    public boolean isConcurrent() {
+        return false;
+    }


The javadoc comment incorrectly states "声明当前 {@link BlockTicker} 是否线程安全" and mentions "默认不启用，此时会将这些机器放置到单线程调度器 (旧方法) 上运行". However, thread safety and concurrent execution are related but distinct concepts. A method being concurrent-safe means it can be called by multiple threads simultaneously without issues, while the default behavior of using a single-threaded scheduler means sequential execution. The documentation should clarify that this method indicates whether the ticker can safely execute in parallel with other tickers, not just general thread safety.

Copilot · 2026-01-21T14:34:24Z

src/main/java/io/github/thebusybiscuit/slimefun4/core/services/holograms/HologramsService.java

+    @SneakyThrows
    public boolean removeHologram(@Nonnull Location loc) {


The @SneakyThrows annotation from Lombok is being used to suppress checked exception handling. While this can make code cleaner, it hides the fact that the method can throw exceptions, making it harder for callers to understand the error conditions. Consider explicitly declaring the throws clause or handling the exception more explicitly, especially for a public API method like removeHologram.

feat: init folia support

a7be2fb

StarWishsama added 🔨 进行中在做了咕咕咕 N 🎉 新功能 labels May 5, 2025

StarWishsama added 3 commits May 6, 2025 22:14

feat(ticker): run asyncable task by location in folia

ee65c10

fix(folia): runSync delay min value should > 0

e750eb4

refactor: replace some scheduler usage

0c61cb0

StarWishsama removed the N label May 22, 2025

StarWishsama added 7 commits July 2, 2025 11:42

Merge branch 'dev' into feature/folia

742f76d

# Conflicts: # src/main/java/city/norain/slimefun4/utils/TaskUtil.java # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java

fix(deps): update FoliaLib maven repo

9d1437d

Merge branch 'dev' into feature/folia

94f61b6

feat(ticker): introduced AsyncTickerService

529ca4a

feat(ticker): shutdown async ticker gracefully

d089f10

fix(energy): use concurrent-safe set for discovering network

fa49cd7

fix(task): TaskQueue should handle runAtLoc/Entity properly

7cd0a8f

StarWishsama linked an issue Jul 15, 2025 that may be closed by this pull request

Ticker 多线程问题 #765

Open

3 tasks

StarWishsama added 7 commits July 16, 2025 22:25

chore: fully use our async ticker service

7e03f83

fix: use teleportAsync

b0469ca

Merge branch 'dev' into feature/folia

9ff6129

fix: enforced concurrency safe

660f472

Merge branch 'dev' into feature/folia

bc85e7f

Merge branch 'dev' into feature/folia

489a68f

# Conflicts: # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java

feat(ticker): introduced custom async ticker config

3b76350

StarWishsama added 🔧 插件兼容性 🤔需要测试对应 PR 需要测试 and removed 🔨 进行中在做了咕咕咕 labels Aug 2, 2025

StarWishsama added 4 commits August 2, 2025 21:12

Merge branch 'dev' into feature/folia

68fdf11

# Conflicts: # src/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/controller/BlockDataController.java

fix(soulbound): soulbound not working in folia

dc8af50

Folia remove support for player respawn related event

fix: async chunk retrieval

5fd00db

Merge branch 'dev' into feature/folia

b66e23e

StarWishsama added 2 commits August 5, 2025 22:33

fix(ci): env var not be filled

f124484

Merge branch 'dev' into feature/folia

b2832fc

balugaq reviewed Aug 15, 2025

View reviewed changes

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java Show resolved Hide resolved

StarWishsama added 6 commits September 15, 2025 12:38

Merge branch 'dev' into feature/folia

b261642

feat(api): introduced isConcurrentSafe for identify concurrent-safe…

d8a7e24

… machine refactor(ticker): adjust thread pool argument for better load balanced performance

refactor: adjust ticker thread pool reject strategy

06f2d5f

fix: add fallback ticker service graceful shutdown

f84248c

Merge branch 'dev' into feature/folia

feb14b6

# Conflicts: # src/main/java/me/mrCookieSlime/CSCoreLibPlugin/general/Inventory/ChestMenu.java

refactor(api): update method signature

1193a7e

StarWishsama added 2 commits December 25, 2025 20:25

chore: followup merge fix

6a2c653

Copilot AI review requested due to automatic review settings December 25, 2025 12:29

Copilot started reviewing on behalf of StarWishsama December 25, 2025 12:29 View session

Copilot AI reviewed Dec 25, 2025

View reviewed changes

StarWishsama added 2 commits December 26, 2025 14:05

Merge branch 'dev' into feature/folia

6441f7c

fix(config): inconsistent config mapping

41e3460

Copilot AI review requested due to automatic review settings December 26, 2025 06:23

Copilot started reviewing on behalf of StarWishsama December 26, 2025 06:23 View session

Copilot AI reviewed Dec 26, 2025

View reviewed changes

StarWishsama added 2 commits January 19, 2026 12:04

Merge branch 'dev' into feature/folia

d082a50

# Conflicts: # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/reactors/Reactor.java

chore: spotless

4dfada9

Copilot AI review requested due to automatic review settings January 19, 2026 04:10

chore: cleanup codes

34b2592

Copilot AI reviewed Jan 19, 2026

View reviewed changes

StarWishsama requested a review from Copilot January 21, 2026 14:28

Copilot started reviewing on behalf of StarWishsama January 21, 2026 14:28 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

		@SneakyThrows
		public boolean removeHologram(@Nonnull Location loc) {

Uh oh!

支持 Folia #1059

Are you sure you want to change the base?

支持 Folia #1059

Uh oh!

Conversation

StarWishsama commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ClayCoffee commented Dec 16, 2025

Uh oh!

StarWishsama commented Dec 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

StarWishsama commented May 5, 2025 •

edited

Loading