Matter Appliance minor refactor #2181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves some common functionality into common-utils.lua, implements do_configure in the subdrivers rather than the main driver, and also contains some minor fixes involving embedded clusters.
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against de08bae |
hcarter-775
approved these changes
Jun 9, 2025
increase test coverage, test doConfigure setpoint limit reads, and move laundry washer test cases to a new test file
The attribute and capability handlers related to temperature are common across the subdrivers that use them and can be moved into the main driver. A few helper functions were moved into the common module so that they can be used by the main driver and sub drivers.
nickolas-deboom
force-pushed
the
matter-appliance-minor-subdriver-refactor
branch
from
c7d7de2 to
800f694
Compare
|
I made an update to move some of the temperature attribute and capability handlers into the main driver and remove them from the subdrivers because these have the same behavior in all cases. I left |
Use `check_field_name_updates`, previously implemented in matter-switch, to update "__supported_temperature_levels", previously used in matter-laundry and matter-dishwasher, to "__supported_temperature_levels_map", which is now used in every subdriver.
nickolas-deboom
commented
Jun 9, 2025
| @@ -0,0 +1,187 @@ | |||
| -- Copyright 2024 SmartThings | |||
There was a problem hiding this comment.
I moved these test cases into their own file in order to properly test the doConfigure logic in test_init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This change moves some common functionality into common-utils.lua, implements do_configure in the subdrivers rather than the main driver, and also contains some minor fixes involving embedded clusters.
Summary of Completed Tests