WWSTCERT-7636/7639 Frient humidity sensor (hmszb 120/hmszb 110) add support #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(HMSZB-120/HMSZB-110)---add-support
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 69 files 449 suites 0s ⏱️ Results for commit b8c288c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against b8c288c |
greens
reviewed
Aug 25, 2025
Comment on lines
47
to
50
| device:configure() | ||
| device.thread:call_with_delay(5, function() | ||
| device:refresh() | ||
| end) |
greens
reviewed
Aug 25, 2025
| 3600, | ||
| humiditySensitivity | ||
| ) | ||
| }) |
There was a problem hiding this comment.
I'd also expect a refresh after 5s here, right? Can you incorporate that into the test?
greens
changed the title
…(HMSZB-120/HMSZB-110)---add-support
greens
reviewed
Sep 3, 2025
There was a problem hiding this comment.
Because of updates to the lua libraries, you'll need to add this expected message to tests where you handle the temperature measurement cluster in order for tests to pass
greens
approved these changes
Sep 5, 2025
…(HMSZB-120/HMSZB-110)---add-support
greens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests