Add support for SBTZB-110 #2358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 69 files 449 suites 0s ⏱️ Results for commit a6b07da. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a6b07da |
greens
reviewed
Aug 25, 2025
Comment on lines
22
to
26
| - id: "frient A/S/SBTZB-110" | ||
| deviceLabel: frient Button | ||
| manufacturer: frient A/S | ||
| model: MBTZB-110 | ||
| deviceProfileName: button-profile | ||
| model: SBTZB-110 | ||
| deviceProfileName: button-profile-frient |
There was a problem hiding this comment.
please create a new fingerprint and leave the existing one as-is.
There was a problem hiding this comment.
Fingerprint restored.
greens
reviewed
Aug 25, 2025
There was a problem hiding this comment.
in general, we use 2-space tabs
greens
reviewed
Aug 25, 2025
| endpoint = 0x23, | ||
| frame_ctrl = 0x04 | ||
| }, | ||
|
|
greens
reviewed
Aug 25, 2025
| }, | ||
| can_handle = function(opts, driver, device, ...) | ||
| return device:get_manufacturer() == "frient A/S" and device:get_model() == "MBTZB-110" | ||
| return device:get_manufacturer() == "frient A/S" and device:get_model() == "SBTZB-110" |
There was a problem hiding this comment.
this will need to remain true for the existing model as well
greens
reviewed
Aug 25, 2025
| added = added_handler, | ||
| }, | ||
| ias_zone_configuration_method = constants.IAS_ZONE_CONFIGURE_TYPE.AUTO_ENROLL_RESPONSE, | ||
| health_check = false, |
There was a problem hiding this comment.
this line should be left as-is
greens
reviewed
Aug 25, 2025
Restore old fingerprint. Fix space tabs. Delete extra line. Restore MBTZB-110 in can_handle. Fix missing lines in main init.lua
greens
reviewed
Aug 27, 2025
| end | ||
|
|
||
| local function init_handler(self, device, event, args) | ||
| local function ias_zone_status_attr_handler(driver, device, zone_status, zb_rx) |
There was a problem hiding this comment.
You could just register generate_event_from_zone_status as the handler for the IAS Zone Status attribute rather than including this extra passthrough function.
greens
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests