Skip to content

Conversation

hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Aug 25, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Create lock-modular profile and add handling for new modular profiling.

Semi-unrelated, this PR changes the PowerSource AttributeList read logic in this driver to match handling seen in other matter drivers, moving the read to the added call.

Summary of Completed Tests

Unit tests updated and new unit tests added to account for modular logic.
Tested on VDA and with a real lock device and the correct optional capabilities are added to the profile.

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

Copy link

github-actions bot commented Aug 25, 2025

File Coverage
All files 85%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 81%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 8c4b93b

Copy link

github-actions bot commented Aug 25, 2025

Test Results

   69 files    450 suites   0s ⏱️
2 343 tests 2 343 ✅ 0 💤 0 ❌
3 938 runs  3 938 ✅ 0 💤 0 ❌

Results for commit 8c4b93b.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants