-
Notifications
You must be signed in to change notification settings - Fork 506
Add modular profile support for new matter lock devices #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hcarter-775
wants to merge
6
commits into
main
Choose a base branch
from
add/modular-lock-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate profile check: Passed - no duplicate profiles detected. |
Invitation URL: |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8c4b93b |
Test Results 69 files 450 suites 0s ⏱️ Results for commit 8c4b93b. ♻️ This comment has been updated with latest results. |
HunsupJung
reviewed
Aug 26, 2025
HunsupJung
reviewed
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Create lock-modular profile and add handling for new modular profiling.
Semi-unrelated, this PR changes the PowerSource AttributeList read logic in this driver to match handling seen in other matter drivers, moving the read to the
added
call.Summary of Completed Tests
Unit tests updated and new unit tests added to account for modular logic.
Tested on VDA and with a real lock device and the correct optional capabilities are added to the profile.