feat: implement React Native gesture composition and advanced handling (#235)#331
Merged
Smartdevs17 merged 1 commit intoApr 26, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #235 — adds a
GestureComposerclass for gesture composition, extends the existing gesture service with additional validation cases, and adds comprehensive tests.New files
src/services/gestureComposer.tsGestureComposerclass — wraps the existinggestureServiceprimitives into a composable, handler-based system:process(sample, longPressTriggered?)— runs validation → priority resolution → haptic feedback → notifies all registered handlersaddHandler(fn)/removeHandler(fn)— register/deregister handlers with fluent chainingenableHapticsoption — togglestriggerGestureFeedback(default: true)ComposedGestureResultwithpriority,direction,swipe,sample, anddebugLabelcomposeGestureHandlers(...fns)— utility to merge multiple handler functions into one, useful for attaching a single composed handler to multiple composerssrc/services/__tests__/gestureComposer.test.ts— 12 tests covering:process— swipe, tap, long-press resultsaddHandlerreturnsthis)composeGestureHandlersordering and reference identitysrc/services/__tests__/gestureService.test.ts— extended with 10 additional tests:resolveGesturePriority— swipe wins over long-press, tap fallbackbuildGestureDebugLabel— field presenceAcceptance criteria coverage
GestureComposer+composeGestureHandlersvalidateHorizontalSwipetest suiteresolveGesturePrioritycovered; swipe > long-press > tapdebugLabelonComposedGestureResulttriggerGestureFeedbackcalled by composer (toggleable)Test plan
jest --testPathPattern=gesture— all tests pass