Protect against frontrunning and sandwich attacks on subscription charges#525
Open
Chidubemkingsley wants to merge 13 commits into
Conversation
|
@Chidubemkingsley Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Chidubemkingsley
force-pushed
the
Protect-against-frontrunning-and-sandwich-attacks-on-subscription-charges
branch
from
7ecac7e to
1f30e8f
Compare
Owner
|
❌ This PR has merge conflicts. Please resolve the conflicts with 🤖 Drips Wave Merge Agent |
- Replace #[contracttype] with #[contracttype(export = false)] on StorageKey enum to bypass XDR LengthExceedsMax limit. - Remove 10 unused API/rate-limit StorageKey variants. - Add missing CreditMemo, CustomerTaxStatus, DigitalGoodsClass, TaxRateEntry, TaxRateChangeLogByJdx, TaxRemittanceLine, TaxRemittanceReport, ReviewCase, SubscriberSubscriptions, and MerchantSubscriptions variants needed by invoice/fraud crates. - Move MEV protection types (ChargeCommitment, MevChargeConfig, GasPriceSnapshot, MevEventKind) from types crate into subscription crate to avoid XDR metadata bloat.
Line 56 had an extra after the statusStyles object, causing TS1128: Declaration or statement expected.
nightly-2023-12-01 is too old to parse the lockfile format in cargo-fuzz v0.13.1 (lock file version 4). Bump to nightly-2024-09-01.
…regenerate typechain factories
…ary/react-native - Replaced react-hooks import with react-native renderHook/act in ThemeContext.test.tsx - Replaced react-hooks import with react-native renderHook/act in useFilteredSubscriptions.test.ts - Updated ThemeContext test 'throws outside provider' to match new error handling behavior - Removed @testing-library/react-hooks from package.json (incompatible with React 19 types) - All tests passing after migration
Chidubemkingsley
force-pushed
the
Protect-against-frontrunning-and-sandwich-attacks-on-subscription-charges
branch
from
9a8dbb6 to
3018db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Quality Gates (All must pass before merge)
Additional Requirements
Reviewers
--- closes #430
This PR will not be mergeable until all quality gates pass.