fix: resolve pull-to-refresh race condition with stale subscriptions …#527
Merged
Smartdevs17 merged 1 commit intoJun 2, 2026
Merged
Conversation
…data - Fix race condition: subscriptions state may not be updated when used in onRefresh callback - Pull-to-refresh may use stale data, causing incorrect UI state Changes: 1. Enhanced useRefresh hook with fetchBeforeClear option for atomic state updates 2. Added refreshSubscriptions method to subscriptionStore for proper data fetching 3. Updated HomeScreen to use new refreshSubscriptions method 4. Combined refreshing and isLoading states in RefreshControl for correct UI feedback 5. Added comprehensive test suite for race condition scenarios Acceptance Criteria Met: Pull-to-refresh always works No stale data shown Loading state correct No infinite refresh loops Technical Details: - Uses inFlightRef to prevent concurrent refreshes - Atomic state updates prevent intermediate renders - Proper error handling ensures clean loading state cleanup - Tested with rapid successive refreshes and error scenarios Files Changed: - src/hooks/useRefresh.ts: Added fetchBeforeClear option - src/store/subscriptionStore.ts: Added refreshSubscriptions method - src/screens/HomeScreen.tsx: Updated onRefresh implementation - src/screens/__tests__/HomeScreen.race-condition.test.ts: New test file - RACE_CONDITION_FIX.md: Comprehensive documentation
|
@ReinaMaze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #42