fix(#58,#68): pre-commit hooks docs + concurrent request tests#431
Merged
Smartdevs17 merged 2 commits intoJun 1, 2026
Merged
Conversation
…current request tests Issue Smartdevs17#58 - Pre-commit hooks (Husky + lint-staged): - husky and lint-staged already declared in root package.json - .husky/pre-commit runs npx lint-staged on staged .ts files - Added Section 4 to CONTRIBUTING.md documenting what runs on commit, setup steps, and --no-verify bypass instructions Issue Smartdevs17#68 - Concurrent request handling tests: - Added 'Concurrent Request Handling' describe block to integration.test.ts with 5 tests asserting real concurrent behavior: * simultaneous deposits processed independently (no merging) * concurrent submits without double-processing * idempotency key deduplication under concurrency * per-user isolation across concurrent requests * partial failure isolation (one failure doesn't affect others) - Fixed pre-existing jest.config.js typo: moduleNameMapping -> moduleNameMapper - Added missing runtime deps: cls-hooked, uuid (required by requestId middleware) - All 44 integration tests pass
|
Someone is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devJaja Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #58
Closes #68
Issue #58 — Pre-commit hooks (Husky + lint-staged)
package.jsonhashuskyandlint-stageddeclared and wired up.husky/pre-commitrunsnpx lint-stagedon every commitlint-stagedruns ESLint + Prettier format check + TypeScript on stagedapi/src/**/*.tsandoracle/src/**/*.ts;cargo checkon stagedcontract/**/*.rsCONTRIBUTING.mddocumenting what runs, setup (npm install), and bypass (git commit --no-verify)Issue #68 — Concurrent request handling tests
Added
Concurrent Request Handlingdescribe block tointegration.test.tswith 5 tests asserting real behavior — no catch-all status assertions:buildUnsignedTransactioncalled exactly N times — no mergingsubmitTransaction+monitorTransactioneach called exactly N timessubmitTransactioncalled onceAlso fixed pre-existing bugs blocking the test suite:
jest.config.js:moduleNameMapping→moduleNameMapper(typo broke@/path aliases)cls-hookedanduuid(required byrequestIdmiddleware)Testing