Implement percentage functions for random number generation #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added synchronous percentage() function to generate random percentages (0 to 1) with optional repetition. - Implemented asynchronous percentageAsync() function to generate random percentages asynchronously with optional repetition. - Created AsyncStream.percentage() to wrap percentageAsync() in an async stream. - Added Stream.percentage() to wrap percentage() in a synchronous stream. - Included error handling for negative repetitions using InvalidArgumentError. These changes introduce support for both synchronous and asynchronous random percentage generation with flexible iteration options.
Pull Request Test Coverage Report for Build 13909962086Details
💛 - Coveralls |
|
Hi @Manya7547! Thanks for your PR! It's mostly good, but there are a couple of things I'd like to improve. I described a couple of little things in the review in the message above. I also suggest reworking your tests a little so that they use data providers, as is currently implemented in other previously written tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce support for both synchronous and asynchronous random percentage generation with flexible iteration options.