feat: Add external link icon to GitHub link on Cache Poisoning page #137#152
Merged
Soham7-dev merged 1 commit intoSoham7-dev:mainfrom Oct 28, 2025
Merged
Conversation
Contributor
Author
|
Just one small request, could you please add the hacktoberfest and hacktoberfest-accepted labels to my PR |
Contributor
Author
|
Hi @Soham7-dev could you please add the hacktoberfest and hacktoberfest-accepted labels to my PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
Description
This pull request resolves issue #137 by adding the external link icon (
/wwwroot/expand-arrows.png) to the "GitHub" link on the Cache Poisoning demonstration page.Changes Made
Views/Home/CachePoisoning.cshtml<img>tag inside the<a>(link) tag. This makes both the "GitHub" text and the new icon clickable, improving user experience.display: inline-flex,align-items: center,gap) to the<a>tag to ensure the text and the icon are perfectly aligned vertically and have clean, consistent spacing.Screenshot
As requested in the issue, here is a screenshot of the final result: