Skip to content

Conversation

@LewisKSaint
Copy link
Collaborator

@LewisKSaint LewisKSaint commented Jul 21, 2025

JIRA

https://sol-jira.atlassian.net/browse/DATAGO-105493

Description

  • API spec updated to support nodePort, this is optional
  • When serviceType is NodePort with no nodePort configuration, random node ports will be assigned
  • When specific nodePort are used, broker configuration will use that.
  • Integration tests with GKE cluster to validate this

Anything for reviewers to be aware of

  • A follow-up documentation will explain the port collision when going with nodePort configuration. With the random port allocation, there will be no port collision

✨ PR Description

Purpose: Add NodePort support to PubSubPlus EventBroker with configurable fixed ports to enable direct access to broker services.

Main changes:

  • Extended BrokerPort struct with optional NodePort field for fixed port assignment
  • Implemented NodePort assignment logic in service controller with appropriate validation constraints
  • Added integration tests for NodePort service type functionality with fixed port values
  • Upgraded operator version from 1.3.0 to 1.4.0 across all configuration files

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

gitstream-cm[bot]

This comment was marked as resolved.

@gitstream-cm
Copy link

gitstream-cm bot commented Jul 21, 2025

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

Comment on lines 109 to 113
kubectl port-forward svc/test-nonha-nodeport-pubsubplus 55555:55555 &
sleep 5
curl -O https://sftp.solace.com/download/SDKPERF_C_LINUX64
tar -xvf SDKPERF_C_LINUX64
pubSubTools/sdkperf_c -cip=tcp://localhost:55555 -mn=1000 -mr=0 -ptl=t1 -stl=t1 | grep "Total Messages"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LewisKSaint have you reviewed this?

gitstream-cm[bot]

This comment was marked as resolved.

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@LewisKSaint LewisKSaint merged commit 278c232 into dev1.4.0 Jul 22, 2025
22 of 23 checks passed
@LewisKSaint LewisKSaint deleted the lewisDATAGO-105493 branch July 23, 2025 15:44
@LewisKSaint LewisKSaint restored the lewisDATAGO-105493 branch July 23, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants