feat(DATAGO-122877): Implement MSSQL tool with pyodbc driver#90
Open
feat(DATAGO-122877): Implement MSSQL tool with pyodbc driver#90
Conversation
Hugo-Pare
commented
Jan 27, 2026
✅ SonarQube Quality Gate - All Passed
Quality gate checks are run for each modified plugin. Click the SonarQube links above for detailed analysis. |
m9p909
approved these changes
Feb 3, 2026
m9p909
left a comment
There was a problem hiding this comment.
- add mssql row count
- add integration tests
- add documentation for MSSQL
- Add mssql specific text types
evenjessie
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Adds Microsoft SQL Server (MSSQL) support to the sam-sql-database-tool plugin, expanding database compatibility beyond PostgreSQL, MySQL, and MariaDB.
How was this change implemented?
pyodbcdependency for MSSQL connectivity andtestcontainers[mssql]for testingsys.tables/sys.partitionsand extended string type detection to includeNVARCHAR,NCHAR,NTEXTSqlServerContainerand pyodbc connection URLautoincrement=Falseon all primary keys to allow explicit ID inserts (MSSQL IDENTITY column restriction)COLUMNkeyword inADD)Key Design Decisions
pyodbcoverpymssqlas it's more widely supported and Microsoft-recommended, though it requires an ODBC Driver to be installed on the host systemautoincrement=Falsein test tables rather than modifying INSERT statements to keep test queries database-agnosticHow was this change tested?
Is there anything the reviewers should focus on/be aware of?
TrustServerCertificate=yesfor self-signed certificates (common in dev/test environments)