feat(DATAGO-118659): Add MCP Gateway and Authentication Proxy documentation #847
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for two authentication and gateway features: the MCP Gateway and the Authentication Proxy. The MCP Gateway enables MCP-compatible clients to interact with SAM agents, while the Authentication Proxy handles OAuth flows without requiring separate redirect URI registrations.
Changes:
- Added MCP Gateway tutorial covering setup, configuration, tool filtering, file handling, and troubleshooting
- Added Authentication Proxy documentation with OAuth flow diagrams and configuration examples
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/docs/documentation/enterprise/auth-proxy.md | Documents the Authentication Proxy feature with OAuth flow diagrams and configuration examples |
| docs/docs/documentation/developing/tutorials/mcp-gateway.md | Provides comprehensive tutorial for setting up and using the MCP Gateway |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
enavitan
left a comment
enavitan
left a comment
There was a problem hiding this comment.
looks good, added a few comments.
Thanks
Eugene
| AG->>+AS: 11. Exchange gateway code for tokens | ||
| AS-->>-AG: Returns access_token, refresh_token | ||
| AG-->>MC: 12. Return access_token to client | ||
| ``` |
There was a problem hiding this comment.
this is a good list, however we don't list anywhere what are the mcp oauth specific endpoints (this is valuable for customers to know when configure ingress rules) this plugin expects to have provisioned.
There was a problem hiding this comment.
Updated the docs
… deployment environment details
…n OAuth2 configuration
|
gilyusolace
left a comment
gilyusolace
left a comment
There was a problem hiding this comment.
Minor comments a structural recommendation at the end to help AI.
| --- | ||
|
|
||
| # MCP Gateway | ||
|
|
There was a problem hiding this comment.
What does "through a standardized interface" mean? Are you referring to JSON-RPC 2.0? If so, maybe that is what you specify:
"through the interface as defined in JSON-RPC 2.0.".
If not, perhaps just drop "through a standardized interface."?
There was a problem hiding this comment.
Through Model Context Protocol standards (MCP)
| Once you have your project set up, add the MCP Gateway plugin: | ||
|
|
||
| ```sh | ||
| sam plugin add my-mcp-gateway --plugin sam-mcp-server-gateway-adapter |
There was a problem hiding this comment.
Is "sam-mcp-server-gateway-adapter" meant to be a variable? If so, recommend you change to ""
There was a problem hiding this comment.
No, it's just the plugin name, my-mcp-gateway is the variable name
|
@gilyusolace A second PR to answer your concerns have been created here: |
4 participants
What is the purpose of this change?
This change adds comprehensive documentation for two important features: the MCP Gateway and the Authentication Proxy. These components enable Agent Mesh to connect with MCP-compatible clients (like Claude Desktop) and handle authentication securely without requiring separate redirect URI registrations with OAuth providers.
How is this accomplished?
Anything reviews should focus on/be aware of?
Verify technical accuracy of the authentication flow diagrams and check if the configuration examples match the actual implementation details.