-
Notifications
You must be signed in to change notification settings - Fork 96
feat(DATAGO-123135): Add ability to preview binary artifacts (PDF. PPTX, DOCX) #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amir-ghasemi
wants to merge
24
commits into
main
Choose a base branch
from
amir/feat-artifact-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1ca6e1f
feat: PDF, PPTX, and DOCX renderers
amir-ghasemi e76a0af
fix: close fullscreen pptx when clicking outside
amir-ghasemi 6cc0b27
Merge branch 'main' of github.com:SolaceLabs/solace-agent-mesh into a…
amir-ghasemi 702e55f
Merge branch 'main' of github.com:SolaceLabs/solace-agent-mesh into a…
amir-ghasemi 25fe1b9
feat: DOCX and PPTX rendering via PDF conversion
amir-ghasemi 3d30c9b
feat: add document conversion service
amir-ghasemi fcc655f
fix: import doc conversion router
amir-ghasemi 05fe313
Merge branch 'main' of github.com:SolaceLabs/solace-agent-mesh into a…
amir-ghasemi 0b7e4fe
fix: allow text selection in addition to pan mode
amir-ghasemi b38b5a0
feat: snip tool
amir-ghasemi a75a957
fix: add feature flag and default to false
amir-ghasemi 72d04b4
fix: snip-to-chat
amir-ghasemi 7c52279
Merge branch 'main' of github.com:SolaceLabs/solace-agent-mesh into a…
amir-ghasemi 557c117
fix: add LRU cache and max conversion file size
amir-ghasemi 6b773c2
fix: Add LibreOffice licence notice
amir-ghasemi 5788473
chore: unit tests
amir-ghasemi bccf90c
fix: update package lock
amir-ghasemi d220ad4
fix: update package-lock.json
amir-ghasemi c2671ab
fix: address review feedback
amir-ghasemi 5e7a09c
chore: remove redundant comments
amir-ghasemi e7f39f7
fix: switch from CDN to local worker
amir-ghasemi ab5a852
fix: sync tests with code update
amir-ghasemi 0da4dc2
Merge branch 'main' of github.com:SolaceLabs/solace-agent-mesh into a…
amir-ghasemi aff4153
Merge branch 'main' of github.com:SolaceLabs/solace-agent-mesh into a…
amir-ghasemi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # LibreOffice Third-Party License Notice | ||
|
|
||
| ## About LibreOffice | ||
|
|
||
| LibreOffice is a free and open-source office productivity software suite developed by The Document Foundation. When the SAM Docker image is built with `INSTALL_LIBREOFFICE=true`, the unmodified LibreOffice packages from Debian are installed as a **separate application** alongside SAM to provide document conversion capabilities (DOCX, PPTX, XLSX to PDF). | ||
|
|
||
| **Important:** LibreOffice is NOT bundled by default. It is only installed when explicitly requested via the `INSTALL_LIBREOFFICE=true` build argument. | ||
|
|
||
| ## License | ||
|
|
||
| LibreOffice is licensed under the **Mozilla Public License Version 2.0 (MPL-2.0)**. | ||
|
|
||
| Some components may also be available under the GNU Lesser General Public License (LGPL). | ||
|
|
||
| ### Mozilla Public License Version 2.0 | ||
|
|
||
| The full text of the MPL-2.0 license can be found at: | ||
| - https://www.mozilla.org/en-US/MPL/2.0/ | ||
|
|
||
| ### LGPL License | ||
|
|
||
| The full text of the LGPL can be found at: | ||
| - https://www.gnu.org/licenses/lgpl-3.0.html | ||
|
|
||
| ## Source Code | ||
|
|
||
| LibreOffice source code is available from: | ||
| - **Official website:** https://www.libreoffice.org/download/source-code/ | ||
| - **Git repository:** https://git.libreoffice.org/core | ||
| - **Debian source packages:** Available via `apt-get source libreoffice-writer-nogui` (when using Debian-based images) | ||
|
|
||
| ## How LibreOffice is Used | ||
|
|
||
| SAM uses LibreOffice in **headless mode** via command-line interface to convert Office documents (DOCX, PPTX, XLSX) to PDF format for in-browser preview. The conversion is performed by calling the `soffice` binary with the `--headless --convert-to pdf` flags. | ||
|
|
||
| No modifications have been made to LibreOffice's source code. The standard Debian packages are installed as-is: | ||
| - `libreoffice-writer-nogui` | ||
| - `libreoffice-impress-nogui` | ||
| - `libreoffice-calc-nogui` | ||
|
|
||
| ## Additional Information | ||
|
|
||
| - **LibreOffice Official Website:** https://www.libreoffice.org/ | ||
| - **The Document Foundation:** https://www.documentfoundation.org/ | ||
| - **LibreOffice License FAQ:** https://www.libreoffice.org/about-us/licenses/ | ||
|
|
||
| --- | ||
|
|
||
| *This notice is provided in compliance with LibreOffice's licensing requirements. LibreOffice is a trademark of The Document Foundation.* | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to make this visible in the UI? (under About?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have provided attribution and link to source code as well as notice during installation. That seems to be checking off all the boxes but, if we still want more assurance, UI visibility can be added. Would need a consult with UX perhaps?