feat(DATAGO-122903): Add support for Bedrock model in init GUI#873
feat(DATAGO-122903): Add support for Bedrock model in init GUI#873TamimiGitHub wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds AWS Bedrock support to the SAM init GUI, allowing users to configure AWS Bedrock as an LLM provider through a user-friendly interface instead of manual configuration.
Changes:
- Added AWS Bedrock as a new LLM provider option with dedicated UI fields for Bedrock-specific credentials
- Implemented conditional logic to bypass standard LLM validation and testing for Bedrock
- Created Bedrock-specific configuration template and environment variable handling
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/shared_config_bedrock.yaml | New template for Bedrock configuration with AWS credential environment variables |
| config_portal/frontend/app/components/steps/init/CompletionStep.tsx | Bypasses provider transformation for Bedrock to preserve the provider identifier |
| config_portal/frontend/app/components/steps/init/AIProviderSetup.tsx | Adds Bedrock-specific form fields and validation, skips connection testing for Bedrock |
| config_portal/frontend/app/common/providerModels.ts | Registers AWS Bedrock in provider options and prefix mappings |
| cli/commands/init_cmd/web_init_step.py | Skips standard model name handling for Bedrock provider |
| cli/commands/init_cmd/orchestrator_step.py | Loads Bedrock-specific template when Bedrock provider is selected |
| cli/commands/init_cmd/env_step.py | Adds Bedrock-specific environment variables to .env configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if llm_provider == "aws_bedrock": | ||
| # For AWS Bedrock, we don't need planning and general model names | ||
| # The model info is already in llm_model_name and aws_model_id | ||
| pass | ||
| else: |
There was a problem hiding this comment.
Empty if-block with only a pass statement. Consider removing the if-block entirely and updating the else condition to check for non-Bedrock providers (e.g., if llm_provider != 'aws_bedrock':).
| if llm_provider == "aws_bedrock": | |
| # For AWS Bedrock, we don't need planning and general model names | |
| # The model info is already in llm_model_name and aws_model_id | |
| pass | |
| else: | |
| # For AWS Bedrock, we don't need planning and general model names | |
| # The model info is already in llm_model_name and aws_model_id | |
| if llm_provider != "aws_bedrock": |
| model: ${BEDROCK_MODEL_NAME} | ||
| model_id: ${BEDROCK_MODEL_ID} |
There was a problem hiding this comment.
The distinction between 'model' and 'model_id' is unclear. Add comments explaining when to use each field and how they differ, especially since both reference similar environment variables.
0215a04 to
58c4891
Compare
|





Summary
Add AWS Bedrock support for the SAM init GUI. The goal is to have a user friendly UI way to configure AWS Bedrock
Changes include
Frontend
Backend
.envshared_config_bedrock.yamlthat handles this changeThe changes allow for configuring bedrock from the GUI init interface