Skip to content

feat(DATAGO-122903): Add support for Bedrock model in init GUI#873

Open
TamimiGitHub wants to merge 1 commit intomainfrom
ta/DATAGO-122903/bedrock
Open

feat(DATAGO-122903): Add support for Bedrock model in init GUI#873
TamimiGitHub wants to merge 1 commit intomainfrom
ta/DATAGO-122903/bedrock

Conversation

@TamimiGitHub
Copy link
Collaborator

@TamimiGitHub TamimiGitHub commented Jan 24, 2026

Summary

Add AWS Bedrock support for the SAM init GUI. The goal is to have a user friendly UI way to configure AWS Bedrock

Changes include

Frontend

  • Added AWS Bedrock to drop down menu
  • Added prefix mapping for bedrock
  • Added state variables for AWS Bedrock fields
  • Bypass bedrock endpoint testing if bedrock is chosen
  • Updated conditional rendering to hide standard fields when AWS Bedrock is selected

Backend

  • Added AWS Bedrock environment variables to .env
  • Created a new shared_config_bedrock.yaml that handles this change

The changes allow for configuring bedrock from the GUI init interface

Screenshot 2026-01-23 at 4 38 45 PM Screenshot 2026-01-23 at 4 38 37 PM

@TamimiGitHub TamimiGitHub requested a review from Copilot January 24, 2026 01:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds AWS Bedrock support to the SAM init GUI, allowing users to configure AWS Bedrock as an LLM provider through a user-friendly interface instead of manual configuration.

Changes:

  • Added AWS Bedrock as a new LLM provider option with dedicated UI fields for Bedrock-specific credentials
  • Implemented conditional logic to bypass standard LLM validation and testing for Bedrock
  • Created Bedrock-specific configuration template and environment variable handling

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
templates/shared_config_bedrock.yaml New template for Bedrock configuration with AWS credential environment variables
config_portal/frontend/app/components/steps/init/CompletionStep.tsx Bypasses provider transformation for Bedrock to preserve the provider identifier
config_portal/frontend/app/components/steps/init/AIProviderSetup.tsx Adds Bedrock-specific form fields and validation, skips connection testing for Bedrock
config_portal/frontend/app/common/providerModels.ts Registers AWS Bedrock in provider options and prefix mappings
cli/commands/init_cmd/web_init_step.py Skips standard model name handling for Bedrock provider
cli/commands/init_cmd/orchestrator_step.py Loads Bedrock-specific template when Bedrock provider is selected
cli/commands/init_cmd/env_step.py Adds Bedrock-specific environment variables to .env configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +84 to +89

if llm_provider == "aws_bedrock":
# For AWS Bedrock, we don't need planning and general model names
# The model info is already in llm_model_name and aws_model_id
pass
else:
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty if-block with only a pass statement. Consider removing the if-block entirely and updating the else condition to check for non-Bedrock providers (e.g., if llm_provider != 'aws_bedrock':).

Suggested change
if llm_provider == "aws_bedrock":
# For AWS Bedrock, we don't need planning and general model names
# The model info is already in llm_model_name and aws_model_id
pass
else:
# For AWS Bedrock, we don't need planning and general model names
# The model info is already in llm_model_name and aws_model_id
if llm_provider != "aws_bedrock":

Copilot uses AI. Check for mistakes.
Comment on lines +14 to +15
model: ${BEDROCK_MODEL_NAME}
model_id: ${BEDROCK_MODEL_ID}
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinction between 'model' and 'model_id' is unclear. Add comments explaining when to use each field and how they differ, especially since both reference similar environment variables.

Copilot uses AI. Check for mistakes.
@TamimiGitHub TamimiGitHub force-pushed the ta/DATAGO-122903/bedrock branch from 0215a04 to 58c4891 Compare January 24, 2026 01:35
@TamimiGitHub TamimiGitHub changed the title DATAGO-122903: Add support for Bedrock model in init GUI feat(DATAGO-122903): Add support for Bedrock model in init GUI Jan 24, 2026
@sonarqube-solacecloud
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant