fix(DATAGO-123535): Handle trailing / in A2A proxy agent url and fix fallback path#926
Open
RohanSreelesh wants to merge 2 commits intomainfrom
Open
fix(DATAGO-123535): Handle trailing / in A2A proxy agent url and fix fallback path#926RohanSreelesh wants to merge 2 commits intomainfrom
RohanSreelesh wants to merge 2 commits intomainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
If a user provided a url with a trailing / in the url, the agent would fail to get added as the url would be constructed with // in the middle. The fallback path is also now aligned with the default in the config.
How was this change implemented?
component.py files were changed for the a2a proxy and the base component file for proxies
How was this change tested?
Is there anything the reviewers should focus on/be aware of?
Nothing