-
Notifications
You must be signed in to change notification settings - Fork 92
chore(DATAGO-123922): Add artifact tags for internal and user-uploaded files #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
efunneko
wants to merge
10
commits into
main
Choose a base branch
from
ed/artifact-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+643
−83
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5bd8312
chore: added tags for internal and uploaded files
efunneko 11de108
chore: remove useless comments
efunneko e8a5f6c
chore: revert unrelated ArtifactBar.tsx changes
efunneko 3230dd8
Merge remote-tracking branch 'origin/main' into ed/artifact-tags
efunneko 9cb7004
fix: handle undefined allArtifacts in ArtifactMessage
efunneko 65bc5c1
fix: add missing artifact tagging props to MockChatProvider
efunneko ab1e82b
fix: remove internal tagging from proxy artifacts
efunneko 38050bb
refactor: extract tag parsing into helper function
efunneko 520db65
test: add unit tests for _parse_tags_param function
efunneko b1f4a3e
refactor: rename "internal" to "working" for artifact tags
efunneko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 35 additions & 11 deletions
46
client/webui/frontend/src/lib/components/chat/artifact/ArtifactMorePopover.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| /** | ||
| * Frontend constants matching backend system tag definitions. | ||
| * System tags are prefixed with "__" to distinguish from user tags. | ||
| */ | ||
|
|
||
| // System artifact tags (must match backend constants in common/constants.py) | ||
| export const ARTIFACT_TAG_USER_UPLOADED = "__user_uploaded"; | ||
| export const ARTIFACT_TAG_WORKING = "__working"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added hidden concept within artifact file list:
and