fix(DATAGO-123990): Optimize declarative test performance #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed webui_api_client fixture from function-scoped to session-scoped to avoid ~800ms TestClient teardown overhead per test. This reduces total test time for declarative tests from ~15.8s to ~10.7s (7 tests). The underlying FastAPI app is already session-scoped, so the TestClient can safely be reused across tests without side effects. Signed-off-by: Edward Funnekotter <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
webui_api_clientfixture from function-scoped to session-scoped to avoid ~800ms TestClient teardown overhead per testTest plan
Jira
DATAGO-123990