fix(DATAGO-123604): add descriptions for workflow logic nodes #967
Conversation
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-967! |
RohanSreelesh
changed the title
|
lgh-solace
left a comment
lgh-solace
left a comment
There was a problem hiding this comment.
If you have time, you could update the tests to use canvas? Thanks!
| )} | ||
|
|
||
| {/* Description (for logic nodes) */} | ||
| {(node.type === "map" || node.type === "switch" || node.type === "loop") && LOGIC_NODE_DESCRIPTIONS[node.type] && ( |
There was a problem hiding this comment.
Not a big deal, but could reduce the number of checks, removing LOGIC_NODE_DESCRIPTIONS[node.type] or something from the condition since we know it's there?
| workflowConfig: null, | ||
| agents: [], | ||
| }, | ||
| play: async () => { |
There was a problem hiding this comment.
The pattern pre-exists in this file, but I think it would be slightly beneficial to use the canvas, like this:
play: async ({ canvas }) => {
// Verify node ID appears twice: once in title header, once in Node ID section
const pollingLoopElements = canvas.getAllByText("polling_loop");
It just makes the tests slightly more efficient since they are pre-scoped to the story container (we do need screen for things like dialogs or toasts since they are outside the canvas).
2 participants
What is the purpose of this change?
Added descriptions for workflow logic nodes. The descriptions are similar to the ones in the docs
How was this change implemented?
Added field picture:
How was this change tested?
Is there anything the reviewers should focus on/be aware of?